zksync version update #8082
Merged
zksync version update #8082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
requested review from
amustapha,
chibie,
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
mds1
force-pushed
the
zksync-bump-for-ethers-provider
branch
from
75fe3e2 to
dbb06ec
Compare
|
@octavioamu @thelostone-mc This is now ready for review/merge, pending any additional API keys we want to include |
mds1
force-pushed
the
zksync-bump-for-ethers-provider
branch
from
dbb06ec to
70ee984
Compare
thelostone-mc
approved these changes
Dec 16, 2020
|
let's roll with INFURA for now ! |
danlipert
approved these changes
Dec 16, 2020
amustapha
approved these changes
Dec 21, 2020
|
@mds1 could you resolve the conflict and we can get this in todayn |
|
@octavioamu Looks like the conflict is because you changed the CDN for the zkSync package. Do you have any context for why this change was made? I don't think it should matter which CDN we use but want to confirm first before resolving the conflict
|
|
@mds1 we had issues with unpkg and it wasn't loading in a few situations so @octavioamu switched it over to jsdeliver which fixed that issue. |
mds1
force-pushed
the
zksync-bump-for-ethers-provider
branch
from
70ee984 to
5c3202e
Compare
|
Ok, just updated the URL 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bump the zksync version to a version which requires us to provide API keys for node providers. Without API keys, ethers falls back to shared API keys which can be throttled. For Infura,
document.contxt.INFURA_V3_PROJECT_ID. Do we have API keys that we can use for Etherscan, Alcehmy, or Pocket?