Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p1: cross chain grants integration #8077

Merged
merged 27 commits into from
Dec 22, 2020
Merged

p1: cross chain grants integration #8077

merged 27 commits into from
Dec 22, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Dec 10, 2020

Description

  • splits code into multiple files within cart
  • fixes up bugs in bounties sync logic
  • updated backend + frontend to accommodate newer chains. starting with CELO + ZIL for starters

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #8077 (492c73f) into master (5265bdb) will decrease coverage by 4.59%.
The diff coverage is 15.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8077      +/-   ##
==========================================
- Coverage   25.35%   20.76%   -4.60%     
==========================================
  Files         329      324       -5     
  Lines       33401    34130     +729     
  Branches     4997     5108     +111     
==========================================
- Hits         8470     7086    -1384     
- Misses      24641    26993    +2352     
+ Partials      290       51     -239     
Impacted Files Coverage Δ
app/app/settings.py 81.35% <ø> (-0.06%) ⬇️
app/app/urls.py 86.20% <ø> (ø)
...d/management/commands/sync_pending_fulfillments.py 0.00% <0.00%> (ø)
app/dashboard/sync/btc.py 19.56% <0.00%> (ø)
app/dashboard/sync/celo.py 14.28% <0.00%> (ø)
app/dashboard/sync/etc.py 14.28% <0.00%> (ø)
app/dashboard/sync/filecoin.py 16.94% <0.00%> (ø)
app/dashboard/sync/zil.py 19.56% <0.00%> (ø)
app/dashboard/tip_views.py 14.85% <0.00%> (-0.06%) ⬇️
app/economy/tx.py 0.00% <0.00%> (-16.10%) ⬇️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24b75d...cb809e2. Read the comment docs.

@thelostone-mc thelostone-mc changed the title wip: grants celo + zil QR support part1: cross chain grants support Dec 18, 2020
@thelostone-mc thelostone-mc changed the title part1: cross chain grants support p1: cross chain grants Dec 18, 2020
@thelostone-mc thelostone-mc changed the title p1: cross chain grants p1: cross chain grants integration Dec 18, 2020
@thelostone-mc thelostone-mc marked this pull request as ready for review December 21, 2020 09:22
Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of fun performance improvements, probably more lurking here

app/grants/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@amustapha amustapha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion, why not merge the migrations 107/108

@thelostone-mc
Copy link
Member Author

@aamustapha forgot to push that in ! nice catch

@thelostone-mc thelostone-mc merged commit f034388 into master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants