fix: update QR code for CELO + cUSD #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the QR string based on celo-org/celo-monorepo#5515 This will be available in version 1.4 of Valora
thelostone-mc
requested review from
amustapha,
chibie,
danlipert,
frankchen07,
octavioamu and
PixelantDesign
as code owners
chibie
approved these changes
Nov 5, 2020
medhakothari
reviewed
Nov 5, 2020
| `celo://wallet/pay?address=${address}&amount=${value}` : | ||
| `celo://wallet/pay?address=${address}`; | ||
| `celo://wallet/pay?address=${address}&amount=${value}&token=${token_name}` : | ||
| `celo://wallet/pay?address=${address}&token=${token_name}`; |
There was a problem hiding this comment.
to clarify, if the token param is not given, the deeplink will default to cUSD, so you can choose whether or not you want to provide it in your deeplink. For CELO though, the param is necessary.
There was a problem hiding this comment.
Yup! thanks for clarifying that @medhak1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the QR string based on celo-org/celo-monorepo#5515
This will be available in version 1.4 of Valora