Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grants): allow update of github project url #7818

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Nov 3, 2020

Description

Users are not able to edit github repo URL of a grant after creation.

This PR makes the github repo URL editable when "Edit Info" is clicked

Fixes

#7788

Testing

https://www.loom.com/share/dfb001c16bb44aac92bcf2914c71b672

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #7818 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7818      +/-   ##
==========================================
+ Coverage   25.36%   25.38%   +0.01%     
==========================================
  Files         328      328              
  Lines       33082    33083       +1     
  Branches     4926     4926              
==========================================
+ Hits         8391     8397       +6     
+ Misses      24408    24403       -5     
  Partials      283      283              
Impacted Files Coverage Δ
app/grants/views.py 11.22% <0.00%> (-0.01%) ⬇️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b1ab7...038de91. Read the comment docs.

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice looks great! @chibie I'm wondering if we can make one small improvement to lengthen the input field to match the others on the form since it seems a bit small right now according to your video. What do you think?

@chibie
Copy link
Contributor Author

chibie commented Nov 5, 2020

@danlipert yes, this commit fixed that. the screen vid was made prior 😄

@thelostone-mc thelostone-mc merged commit 5caeac4 into gitcoinco:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants