Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: harmony integarion #7779

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Oct 28, 2020

Description
  • integrates harmony into bounties
  • added logo behind staff
  • does minimal refactoring to code
  • improves check to see if txn has already been recorded

token_name: ONE
chainID: 1000
decimal: 18

Pieces/Steps

  • create bounty
  • sync fulfillment with chain
  • inject provider and connect to network
  • actual transfer // this doesn't work due to bug in the extension - signing with private key to test for now
  • record activity
Testing

image

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #7779 into master will increase coverage by 0.00%.
The diff coverage is 13.63%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7779   +/-   ##
=======================================
  Coverage   25.35%   25.36%           
=======================================
  Files         328      329    +1     
  Lines       33096    33145   +49     
  Branches     4929     4945   +16     
=======================================
+ Hits         8392     8406   +14     
- Misses      24421    24456   +35     
  Partials      283      283           
Impacted Files Coverage Δ
...d/management/commands/sync_pending_fulfillments.py 0.00% <0.00%> (ø)
app/dashboard/models.py 50.01% <ø> (ø)
app/dashboard/sync/helpers.py 27.27% <ø> (ø)
app/dashboard/views.py 10.31% <0.00%> (ø)
app/dashboard/sync/harmony.py 14.28% <14.28%> (ø)
app/dashboard/utils.py 40.23% <33.33%> (-0.04%) ⬇️
app/grants/sync/helpers.py 20.00% <0.00%> (-1.74%) ⬇️
app/retail/utils.py 10.17% <0.00%> (-0.10%) ⬇️
...perftools/management/commands/create_page_cache.py 0.00% <0.00%> (ø)
.../management/commands/sync_pending_contributions.py 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0e56b...19f2750. Read the comment docs.

@danlipert danlipert marked this pull request as ready for review October 29, 2020 09:59
@thelostone-mc thelostone-mc requested a review from chibie October 30, 2020 13:41
@danlipert
Copy link
Contributor

@thelostone-mc mark as draft until they get back to us?

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Nov 5, 2020

@danlipert i'd lean towards getting this in cause and have it ready behind a staff flag (to avoid having this go stale)

@danlipert danlipert requested a review from amustapha as a code owner November 5, 2020 11:12
@thelostone-mc thelostone-mc merged commit 9dea6d5 into gitcoinco:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants