enables sending of kudos on the xdai network right from the browser. #7737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
mind if i get this into master? @owocki |
thelostone-mc
approved these changes
Nov 19, 2020
|
sure! |
|
pr updated |
|
@thelostone-mc can i merge for #7919 |
|
can i merge this? |
danlipert
approved these changes
Dec 22, 2020
|
Hi all! I got the following error "You are not on the right web3 network. Please switch to xdai". I was already on xdai network! Tried a CTRL+R, but still received the same message. I'm using Metamask with a Ledger wallet. I've used the xdai network to get some honey, just before this... |
|
its not deployed yet. @danlipert can let us know when the deploy is happening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enables sending of kudos on the xdai network right from the browser.
Refers/Fixes
broken UX on the live site
Testing
tested locally works fine.
the only wrinkle is that the kudos price is in finney (based on ETH). we could perhaps transpose that to an xDAI price with conversion rates.. but thats added complexity. i kinda feel like its not worth the effort since kudos isnt a large forward development priority for us. but am open to feedback if not.