migrates results page to consolidate the story #7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
danlipert
reviewed
Oct 21, 2020
| ["February 2018", 16302, 7391, 0, 0, 0, 0], | ||
| ["March 2018", 26390, 8302, 0, 0, 0, 0], | ||
| ["April 2018", 37342, 10109, 0, 0, 0, 0], | ||
| ["December 2017", 5534 + 2011, 0, 0], |
There was a problem hiding this comment.
A note to anyone else reviewing this, I actually think leaving it like this instead of doing the calculations and writing the sum directly is a great idea, because this shows where the number is coming from and what the history of this change is. Very slight performance hit vs more understandable code is usually a good idea.
danlipert
approved these changes
Oct 21, 2020
octavioamu
approved these changes
Oct 23, 2020
thelostone-mc
approved these changes
Oct 28, 2020
|
https://bits.owocki.com/eDuPejxe i'm reverting this due to "other" taking over the early months data + the negative month it created on the data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrates results page to consolidate the story
tips + bounties => hackathons
ads, ecosystem => other products
Refers/Fixes
convo with mike kriak asking why our stats dont show our current major projects
Testing
tested locally