Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic User Directory / sharable searches v0. #7712

Merged
merged 11 commits into from
Oct 28, 2020

Conversation

androolloyd
Copy link
Contributor

@androolloyd androolloyd commented Oct 20, 2020

Description

Updates for Sharing Searches.

  • Url Params are now fed into the internal store and the UI is updated to reflected the loaded searches.
  • Url Rewrites for sharing, as the search is updated the URL is adjusted as well to enable easy sharing.
Refers/Fixes
Testing

@androolloyd androolloyd marked this pull request as ready for review October 21, 2020 16:06
@androolloyd androolloyd changed the title [WIP] [BUGS] Feature/user directory elastic updates Feature/user directory elastic updates Oct 21, 2020
@androolloyd androolloyd changed the title Feature/user directory elastic updates Elastic User Directory / sharable searches v0. Oct 21, 2020
@@ -1010,6 +1010,75 @@ function shuffleArray(array) {
return array;
}


const getAllUrlParams = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this function can be a lot more simple with https://developer.mozilla.org/pt-BR/docs/Web/API/URLSearchParams

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #7712 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7712   +/-   ##
=======================================
  Coverage   25.42%   25.42%           
=======================================
  Files         328      328           
  Lines       33044    33044           
  Branches     4918     4919    +1     
=======================================
  Hits         8401     8401           
+ Misses      24356    24351    -5     
- Partials      287      292    +5     
Impacted Files Coverage Δ
app/marketing/mails.py 11.88% <0.00%> (-0.03%) ⬇️
app/quests/views.py 16.22% <0.00%> (ø)
app/retail/emails.py 20.43% <0.00%> (ø)
app/dashboard/views.py 10.35% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)
app/dashboard/models.py 50.01% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a58aee...89832ae. Read the comment docs.

@danlipert danlipert merged commit b9327e0 into master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants