Add project submission #7704
Merged
Add project submission #7704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavioamu
requested review from
danlipert,
frankchen07,
PixelantDesign and
thelostone-mc
as code owners
| @@ -29,8 +29,12 @@ const submitProject = (logo, data, callback) => { | |||
| if (callback) { | |||
| callback(response); | |||
| } | |||
| if (document.location.pathname.includes('fulfill')) { | |||
| document.location.reload(); | |||
There was a problem hiding this comment.
why do we reload ? i didn't get this 😅
There was a problem hiding this comment.
is not the most elegant way I know but the form need the project pk and that hackathon projects is used in many places, so in some point we can just add that to the data form, but that will need a lot of changes on the form approach, and as we are planning to move that form to vue doesn't make sense to invest a lot of time. fair?
chibie
suggested changes
Oct 19, 2020
chibie
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if start work project post failed the user will not able to submit work
Gives the user the ability to create a project on submission if there is not projects.
working hours not decimals
Refers/Fixes
fix #7695
Testing