Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution ingest script updates #7686

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Contribution ingest script updates #7686

merged 2 commits into from
Nov 11, 2020

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Oct 15, 2020

Update contribution ingestion script:

  • Only use checksum addresses
  • Add comments to clarify input arguments

@thelostone-mc thelostone-mc changed the base branch from stable to master October 28, 2020 10:44
danlipert
danlipert approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - will have to have a v2 or update this one once we move to batch txns right? so hopefully round 9

@mds1
Copy link
Contributor Author

mds1 commented Nov 10, 2020

Yep, we will need to update once we implement the zksync batch txs, since there no longer will be a Gitcoin zkSync address. It should only be a small change though

@amustapha amustapha mentioned this pull request Nov 10, 2020
Merged
@thelostone-mc thelostone-mc merged commit c037172 into gitcoinco:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibie chibie chibie approved these changes

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@danlipert danlipert danlipert approved these changes

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@octavioamu octavioamu Awaiting requested review from octavioamu

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mds1 @danlipert @thelostone-mc @chibie