Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounty : minor changes #768

Merged
merged 1 commit into from
Apr 6, 2018
Merged

bounty : minor changes #768

merged 1 commit into from
Apr 6, 2018

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Apr 2, 2018

  • changed the order of action buttons
  • start work turns white on starting work
  • added svg background to comment
  • fixed margin between action buttons

x

x 9 24 19 pm

The change in order of buttons and color was implemented as discussed offline with @PixelantDesign

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Apr 2, 2018

@mbeacom Still a lil uneasy on showing the change in actions before we fire the API. (but if we do it post the API fire -> everything seems super slow )

Checkout the network tabs in the gif

@codecov
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   33.99%   33.95%   -0.04%     
==========================================
  Files         101      101              
  Lines        5775     5695      -80     
  Branches      672      666       -6     
==========================================
- Hits         1963     1934      -29     
+ Misses       3733     3685      -48     
+ Partials       79       76       -3
Impacted Files Coverage Δ
app/gitcoinbot/views.py 34.61% <0%> (-2.43%) ⬇️
app/tdi/views.py 18% <0%> (-1.08%) ⬇️
app/retail/views.py 41.02% <0%> (-1%) ⬇️
app/faucet/views.py 25.33% <0%> (-0.99%) ⬇️
app/marketing/mails.py 13.73% <0%> (-0.86%) ⬇️
app/external_bounties/views.py 17.82% <0%> (-0.81%) ⬇️
app/external_bounties/models.py 54.38% <0%> (-0.79%) ⬇️
app/marketing/views.py 10.46% <0%> (-0.38%) ⬇️
app/dashboard/views.py 17.31% <0%> (-0.34%) ⬇️
app/dashboard/helpers.py 29.58% <0%> (-0.16%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e767c...e14d8a8. Read the comment docs.

@mbeacom
Copy link
Contributor

mbeacom commented Apr 4, 2018

@PixelantDesign Are you good with these changes?

@thelostone-mc thelostone-mc mentioned this pull request Apr 4, 2018
3 tasks
@PixelantDesign
Copy link
Contributor

@mbeacom @thelostone-mc Yes! Thank you!!!!!!!!!!!

@owocki
Copy link
Contributor

owocki commented Apr 4, 2018

mind resolving the conflicts here and we can merge?

@thelostone-mc
Copy link
Member Author

@owocki Done !!

- changed the order of action buttons
- start work turns white on starting work
- added svg background to comment
- fixed margin between action buttons
@owocki owocki merged commit 6d13c6a into gitcoinco:master Apr 6, 2018
@owocki owocki removed the in progress label Apr 6, 2018
@thelostone-mc thelostone-mc deleted the touches branch April 7, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants