Adds APIs to support gathering of minimal export of grants contributor addresses, with no other information exported. #7655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
owocki
commented
Oct 12, 2020
app/grants/views.py
Outdated
| end = timezone.datetime(2020, 7, 3) | ||
| if round_id == 7: | ||
| start = timezone.datetime(2020, 9, 15) | ||
| end = timezone.datetime(2020, 10, 3) |
There was a problem hiding this comment.
i suppose in future rounds we could lookup in the GrantCLR table, but the fact that the 'round_num' field of that table isntreally a number makes me feel like its not perfect..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds APIs to support gathering of minimal export of grants contributor addresses, with no other information exported.
This is useful so that if projects ever want to send a POAP or any other NFT to celebrate their conributions to grants, to these users, they can now do so.
There are a few exports available
Refers/Fixes
https://twitter.com/owocki/status/1314593279988568066
Testing
Testedl locally