-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean branch of projects v2 #7638
Changes from 5 commits
a419228
583e5e2
2911e0a
0e0bec9
7cbf658
91a98f9
84d80b9
cc7f34e
f4a7358
76877ed
ffb05c2
6161f57
c8479ee
a6f9d0e
58c3a97
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# Generated by Django 2.2.4 on 2020-10-08 02:13 | ||
|
||
import django.contrib.postgres.fields | ||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('dashboard', '0153_hackathonevent_use_circle'), | ||
] | ||
|
||
operations = [ | ||
migrations.AddField( | ||
model_name='hackathonproject', | ||
name='categories', | ||
field=django.contrib.postgres.fields.ArrayField(base_field=models.CharField(max_length=200), blank=True, default=list, size=None), | ||
), | ||
migrations.AddField( | ||
model_name='hackathonproject', | ||
name='tech_stack', | ||
field=django.contrib.postgres.fields.ArrayField(base_field=models.CharField(max_length=200), blank=True, default=list, size=None), | ||
), | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,6 +124,18 @@ <h5 class="text-center font-title">{% trans "Submit a Plan" %}</h5> | |
<input type="url" class="form-control" name="work_url" id="work_url" placeholder="https://github.com/gitcoinco/web" required> | ||
</div> | ||
|
||
<div class="form-group mt-4"> | ||
<label class="font-weight-semibold" for="videodemo_url">Select video provider</label> | ||
<select name="videodemo-provider"> | ||
<option value=""><i class="fa fa-youtube"></i> Youtube</option> | ||
<option value=""><i class="fa fa-vimeo">Vimeo</option> | ||
<option value=""><i class="fa fa-loom">Loom</option> | ||
<option value=""><i class="fa fa-video">HTML5 video</option> | ||
</select>> | ||
<label class="font-weight-semibold" for="videodemo-url">Link to Video Demo</label> | ||
<input type="url" class="form-control" name="work_url" id="work_url" placeholder="https://github.com/gitcoinco/web" required> | ||
</div> | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if someone pick html5 are we going to host the video? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, this is URL only. This could be hosted for example in skynet. I recently see some hackathon demos hosted in skynet. |
||
<div class="from-group mb-3 mt-4"> | ||
<label class="font-weight-semibold" for="project_profiles">Team members</label> | ||
<div class="form__select2 g-multiselect"> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -92,6 +92,13 @@ <h4 class="text-center mb-4">{% trans "Submit Work" %}</h4> | |
{% endfor %} | ||
</select> | ||
</div> | ||
<div class="mt-2"> | ||
<label class="form__label" for="videoDemoLink">{% trans "Video demo Link" %}</label> | ||
<input name='videoDemoLink' id='videoDemoLink' class="form__input font-body" type="text" | ||
placeholder="https://youtu.be/DJartWzDn0E" value="" | ||
required | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this should be required, not every bounty make sense to have a video There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed @octavioamu, this was required only for hackathon prizes (bounties) |
||
/> | ||
</div> | ||
{% endif %} | ||
|
||
{% if bounty.web3_type == 'fiat' %} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,40 @@ <h2 class="h5 text-center font-weight-bold mb-4">Let's Get Started!</h2> | |
<div class="form-group mt-4"> | ||
<label class="font-weight-semibold" for="work_url">Project Github Repository or Link to Pull Request</label> | ||
<input type="url" class="form-control" name="work_url" id="work_url" value="{{project_selected.work_url}}" placeholder="https://github.com/gitcoinco/web" required> | ||
</div> | ||
<div class="form-group mt-4"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fix up indenation There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yah lets plz fix this @zoek1 |
||
<label class="font-weight-semibold" for="videodemo-url">Link to Video Demo</label> | ||
<div class="d-flex"> | ||
<select class="form-control col-3 mr-2" name="videodemo-provider" id="videodemo-provider"> | ||
<option value="youtube" {% if project_selected.extra.video_provider == 'youtube' %}selected{% endif %}>Youtube</option> | ||
<option value="vimeo" {% if project_selected.extra.video_provider == 'vimeo' %}selected{% endif %}>Vimeo</option> | ||
<option value="loom" {% if project_selected.extra.video_provider == 'loom' %}selected{% endif %}>Loom</option> | ||
<option value="generic" {% if project_selected.extra.video_provider == 'generic' %}selected{% endif %}>HTML5 video</option> | ||
</select> | ||
<input type="url" class="form-control" name="videodemo-url" id="videodemo-url" value="{{project_selected.extra.video_url}}" placeholder="https://www.youtube.com/watch?v=DJartWzDn0E"> | ||
</div> | ||
</div> | ||
|
||
<div class="from-group mb-3 mt-4"> | ||
<label class="font-weight-semibold" for="project_stack">Built With <small>Add Tech Stack</small></label> | ||
<div class="form__select2 g-multiselect"> | ||
<select id="project_stack" class="project__tags" name="tech-stack[]" multiple="multiple" aria-describedby="profilesHelp" required> | ||
{% for stack in project_selected.tech_stack %} | ||
<option selected="selected" value="{{ stack }}">{{ stack }}</option> | ||
{% endfor %} | ||
</select> | ||
</div> | ||
</div> | ||
|
||
<div class="from-group mb-3 mt-4"> | ||
<label class="font-weight-semibold" for="project_categories">Categories <small>Add Categories</small></label> | ||
<div class="form__select2 g-multiselect"> | ||
<select id="project_categories" class="project__tags" name="categories[]" multiple="multiple" aria-describedby="profilesHelp" required> | ||
{% for category in project_selected.categories %} | ||
<option selected="selected" value="{{ category }}">{{ category }}</option> | ||
{% endfor %} | ||
</select> | ||
</div> | ||
</div> | ||
<div class="from-group mb-3 mt-4"> | ||
<label class="font-weight-semibold" for="project_profiles">Team Members (Optional) <small>Add Gitcoin Usernames</small></label> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zoek1 it seems this block of code is unreached cause the video url isn't saved in db when i submit.
instead i get
Error in render: "TypeError: Cannot read property 'url' of undefined
in the console.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's two things here: the first is keyup listen on changes on the field with the id #videodemo-url, this doesn't requires an existing value, it will evaluate while the user write something on such field.
The second Is a good catch, i fixed that with the latest commit also that prevent refresh the data in the page. Thanks for review It!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zoek1
the second issue has been resolved. 👍 💯
for the first issue about video not saving in db, kindly observe the recording below,
https://www.loom.com/share/87ce5d66853d45b9b2f713604a7c907b
if
keyup
doesn't work as expected, how about invokinggetVideoMetadata
on submit?ps: i tested on google chrome browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ @PixelantDesign / @zoek1 will have to wait until this gets resolved