Fix/show only mainnet bounties #7637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b into fix/show-only-mainnet-bounties
chibie
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
octavioamu
reviewed
Oct 12, 2020
app/dashboard/models.py
Outdated
| # Bounty QuerySet Manager | ||
| objects = BountyQuerySet.as_manager() | ||
| # Bounty Manager from QuerySet | ||
| objects = BountyManager.from_queryset(BountyQuerySet)() |
There was a problem hiding this comment.
how this will impact the ability to filter by rinkeby bounties on the explorer?
There was a problem hiding this comment.
@octavioamu oops... should i take off rinkeby filter in production, since we only want to deal with mainnet in production?
There was a problem hiding this comment.
still need to be able to filter by network in some places, is just the post on the townsquare need to be avoided on prod
There was a problem hiding this comment.
@octavioamu all set now. i've excluded explorer
…b into fix/show-only-mainnet-bounties
…b into fix/show-only-mainnet-bounties
…b into fix/show-only-mainnet-bounties
octavioamu
approved these changes
Nov 11, 2020
thelostone-mc
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on this #7584
This resolves
ValueError invalid literal for int() with base 10: ''noticed in prodhttps://www.loom.com/share/35eab9652d2b440b8fe3729c0d940eb6
Refers/Fixes
https://sentry.io/organizations/gitcoin/issues/1941745874/?referrer=slack