Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator fixes for matches #7612

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Validator fixes for matches #7612

merged 3 commits into from
Oct 5, 2020

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Oct 5, 2020

Changes:

  • Add page to transfer funds from Gitcoin zkSync wallet to regular zkSync wallet
  • Validator now handles cases where L1 tx fails or L1 tx has no event logs
  • Add new grant ingestor command

@mds1 mds1 requested a review from owocki October 5, 2020 17:52
@owocki
Copy link
Contributor

owocki commented Oct 5, 2020

@mds1 @thelostone-mc i will merge this now + ingest the failed contributions. how are we notifying the users who had failed zksync tranfsers to get them to retry / can someone else manage that pls?

@owocki owocki merged commit 6ac2f3a into gitcoinco:stable Oct 5, 2020
@thelostone-mc
Copy link
Member

@zoek1 could you fix this up today please?
#7590 (comment) so that duplicate mails don't get sent out

@zoek1 zoek1 mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@owocki owocki Awaiting requested review from owocki

@danlipert danlipert Awaiting requested review from danlipert

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@octavioamu octavioamu Awaiting requested review from octavioamu

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mds1 @owocki @thelostone-mc