Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tribe v3 #7595

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Feature/tribe v3 #7595

merged 4 commits into from
Oct 13, 2020

Conversation

sanchaymittal
Copy link
Contributor

@sanchaymittal sanchaymittal commented Oct 2, 2020 •
edited
Loading

Description

Video Demo: https://www.loom.com/share/1955e703edf5495e818f16284169b541

  • Put Following and Followers (under current Followers tab) into the People tab
  • Remove Tribes and Followers tab
  • Four sub-tabs: Core Team, Followers, Following & Leaderboard
  • Keep the Leaderboard view.
  • Core Team can view can be the same as Followers/Following (with Chat)
Refers/Fixes

#7552

Testing

@sanchaymittal
chg: people, followers & tribe tabs under org view
0b0d6f1 
- Put Following and Followers (under current Followers tab) into the People tab
- Remove Tribes and Followers tab
- Four sub-tabs: Core Team, Followers, Following & Leaderboard
- Keep the Leaderboard view.
- Core Team can view can be the same as Followers/Following (with Chat)
@sanchaymittal
rmv: tab_follow
dc4ebb5 
chg: clean tab_people
@sanchaymittal sanchaymittal changed the title Feature/tribe v3 #7552 Feature/tribe v3 Oct 2, 2020
@sanchaymittal sanchaymittal marked this pull request as ready for review October 2, 2020 14:49
PixelantDesign
PixelantDesign reviewed Oct 2, 2020
View reviewed changes
Copy link
Contributor

@PixelantDesign PixelantDesign left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good! Could we order the tabs

Leaderboard, Core Team, Followers & Following

Could you also show responsive views?

@thelostone-mc
Copy link
Member

@PixelantDesign I see the suggest bounty feature is removed as well ?
If this is intended -> @sanchaymittal we would have to remove that code as well

either that or it has to be pushed to it's own tab

@sanchaymittal
Copy link
Contributor Author

@PixelantDesign I see the suggest bounty feature is removed as well ?
If this is intended -> @sanchaymittal we would have to remove that code as well

either that or it has to be pushed to it's own tab

Code is removed, it was present in tab_tribe: https://github.com/gitcoinco/web/pull/7595/files#diff-173d59f8e2d92e30a5f56a9ec0830c7fL60

@thelostone-mc
Copy link
Member

thelostone-mc commented Oct 5, 2020 •
edited
Loading

@sanchaymittal I'm looking at the PR and I still see suggest_bounty.html in the codebase on your branch which would now be dead code
Additionally, all the CSS + JS associated with it still present
All of these would need to be weeded out if the feature is being retired

@sanchaymittal
Copy link
Contributor Author

@sanchaymittal I'm looking at the PR and I still see suggest_bounty.html in the codebase on your branch which would now be dead code
Additionally, all the CSS + JS associated with it still present
All of these would need to be weeded out if the feature is being retired

Looking into this...

@sanchaymittal sanchaymittal reopened this Oct 7, 2020
@sanchaymittal
Copy link
Contributor Author

sanchaymittal commented Oct 7, 2020 •
edited
Loading

@thelostone-mc Removed the dead code. CSS files are still is used by suggested bounty code in tribes-vue.

thelostone-mc
thelostone-mc requested changes Oct 12, 2020
View reviewed changes
Copy link
Member

@thelostone-mc thelostone-mc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent fixes needed! I just left comments on a few but there are a few more
Cant seem to find the css rules being removed either!

Are we sure that all the css rules are being used?

app/dashboard/templates/profiles/tab_people.html
{{org}}
<div class="tab-projects d-flex flex-column">

{% if foltab == 'core_team' %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it should be renamed to something common as all the other tabs are using the same css styling too
Screenshot 2020-10-12 at 7 41 07 PM

app/dashboard/templates/profiles/tab_people.html Outdated Show resolved Hide resolved
app/dashboard/templates/profiles/tab_people.html Outdated Show resolved Hide resolved
@thelostone-mc thelostone-mc merged commit a9e910c into master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@octavioamu octavioamu octavioamu approved these changes

@PixelantDesign PixelantDesign PixelantDesign approved these changes

@danlipert danlipert Awaiting requested review from danlipert

@frankchen07 frankchen07 Awaiting requested review from frankchen07

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanchaymittal @thelostone-mc @PixelantDesign @octavioamu