Alpha Tag #758
Alpha Tag #758
Conversation
| @@ -1126,20 +1126,17 @@ input.is-invalid { | |||
| } | |||
|
|
|||
| #alpha{ | |||
| color: #a78600; | |||
| color: #000000; | |||
There was a problem hiding this comment.
Bookkeeping but think we are just using `color: black;' throughout the codebase. @thelostone-mc?
There was a problem hiding this comment.
Well I believe we had agreed to stick to the hex color, so as to keep it uniform throughout ! Else we end up with names in a few areas and hex code in the rest !
There was a problem hiding this comment.
Whoops! @willsputra please disregard :)
app/assets/yge/css/main.css
Outdated
| font-weight: 100; | ||
| padding: 2px 7px; | ||
| font-weight: 100; | ||
| font-family: 'Muli', sans-serif; |
There was a problem hiding this comment.
Indentation off on this line and previous
|
@willsputra dropped some super minor comments for ya to take a look at when you get a moment :) Overall LGTM but I did not test. @thelostone-mc got some cycles? 👍🏻 @willsputra #685 (comment) are the images per this comment up to date or has this changed a bit? If there are some changes please add updated pics to #685 when you get a moment but if not disregard. Thanks! Great work! :) |
There was a problem hiding this comment.
@mkosowsk Yup pulled it in and checked it out ^_^
Everything looks solid except for the tag on the leaderboard page on mobile + indentation fix
@willsputra Could you check that out ? Let's get this merged post that
|
Per @willsputra |
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=======================================
Coverage 33.95% 33.95%
=======================================
Files 101 101
Lines 5695 5695
Branches 666 666
=======================================
Hits 1934 1934
Misses 3685 3685
Partials 76 76Continue to review full report at Codecov.
|
|
@willsputra rebase gone wrong ? :P There are 15 commits |
|
@thelostone-mc yeah might need your help sorry 😞 would have to improve my git knowledge! |
|
Pinging you over slack !! |
|
LGTM, this PR has earned the Mitch Kosowski Seal of Approval™ 💪🏻🤠👍🏻 @willsputra mind sharing with the community what technique you used to get down to 1 commit? 👍🏻 @thelostone-mc truly the community is in the presence of a Git master 😳 |
There was a problem hiding this comment.
lgtm @PixelantDesign Are you good with the attached visual changes?
|
with the guidance of Git master @thelostone-mc :
|
PixelantDesign
changed the title
Description
Added alpha tag
Checklist
Affected core subsystem(s)
Testing
Refers/Fixes
Fixes: #685