Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add participants pre hack #7545

Merged
merged 9 commits into from
Oct 7, 2020

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Sep 28, 2020

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app/dashboard/tests/test_users_list.py:90 UsersListTest.test_user_list is failing looking at travis

@PixelantDesign
Copy link
Contributor

@zoek1

@zoek1
Copy link
Contributor Author

zoek1 commented Oct 1, 2020

Fixed the problem with test_user_list @thelostone-mc

@@ -108,7 +108,7 @@
</small>
</div>
</div>
{% endif %}
{% endif %}card card-user shadow-sm border-0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you have a few classes playing outside in plain text 😃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I believe this PR is meant to solve

enhancement to the pre-hack dev experience

with user story:

As a user I 'dl ike to know who are the notable participants so that I can decide whether to participate in the hackathon.

However, if I do not register for a hackathon, I'm unable to see the participants. Should this still be so?

Copy link
Contributor

@aamustapha-gitcoin aamustapha-gitcoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @zoek1, this looks fantastic. 🥂

Copy link
Contributor

@amustapha amustapha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @zoek1, this looks fantastic. 🥂

@thelostone-mc thelostone-mc merged commit 0744ed7 into gitcoinco:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants