Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factors trust bonus into a parameter on profile #7534

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Sep 25, 2020

Description

factors trust bonus into a parameter on profile

we should port this into the grants/clr code to manage the trust bonus additions there in a DRY way :)

Refers/Fixes

convos with aditya/frank

Testing

tested locally

@owocki
Copy link
Contributor Author

owocki commented Sep 25, 2020

@frankchen07 can we use this code to massively simplify this part of the clr code ??? https://github.com/gitcoinco/web/blob/master/app/grants/clr.py#L207-L222

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #7534 into stable will decrease coverage by 0.00%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #7534      +/-   ##
==========================================
- Coverage   26.00%   26.00%   -0.01%     
==========================================
  Files         309      309              
  Lines       31198    31207       +9     
  Branches     4619     4622       +3     
==========================================
+ Hits         8114     8115       +1     
- Misses      22805    22808       +3     
- Partials      279      284       +5     
Impacted Files Coverage Δ
app/dashboard/models.py 49.54% <11.11%> (-0.12%) ⬇️
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.46% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3cd1d...bd1d04f. Read the comment docs.

@owocki
Copy link
Contributor Author

owocki commented Oct 6, 2020

@frankchen07 can you update your code to use this as the source of truth for the users trust bonus?

@thelostone-mc is this ok to ship? i want to ask participants in gitcoinco/skunkworks#187 to update it

@owocki
Copy link
Contributor Author

owocki commented Nov 3, 2020

@frankchen07 @thelostone-mc pls review. the idena integration blocks on this ( #7646 )

@owocki owocki mentioned this pull request Nov 3, 2020
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankchen07 this looks alright to me !
It just wires in the prop and we'll have to update clr.py to use this prop

@thelostone-mc thelostone-mc changed the base branch from stable to master November 5, 2020 11:25
@thelostone-mc thelostone-mc merged commit c28d1c5 into master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants