Start tx validator v2, and fix bug in zkSync validations #7510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
app/economy/tx.py
Outdated
| url = f'https://api.aleth.io/v1/{endpoint}?filter[account]=' + address + '&page%5Blimit%5D=100' | ||
| if from_address: | ||
| print('wwww') |
There was a problem hiding this comment.
^ do we wanna remove all the print stmt :P
There was a problem hiding this comment.
Oops, yea those were leftover from my expert debugging techniques. Removed in f61690e
octavioamu
suggested changes
Sep 23, 2020
app/economy/tx.py
Outdated
| url = f'https://api.aleth.io/v1/{endpoint}?filter[account]=' + address + '&page%5Blimit%5D=100' | ||
| if from_address: | ||
| print('wwww') |
There was a problem hiding this comment.
Oops, yea those were leftover from my expert debugging techniques. Removed in f61690e
thelostone-mc
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new validator that will be updated as necessary going forward. Also fixes a bug in the zkSync validator.
cc @owocki