Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard/views): invalid attribute call #7506

Merged
merged 6 commits into from
Sep 23, 2020

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Sep 23, 2020

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #7506 into master will decrease coverage by 0.01%.
The diff coverage is 17.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7506      +/-   ##
==========================================
- Coverage   26.11%   26.09%   -0.02%     
==========================================
  Files         307      308       +1     
  Lines       30676    30772      +96     
  Branches     4541     4561      +20     
==========================================
+ Hits         8010     8029      +19     
- Misses      22392    22469      +77     
  Partials      274      274              
Impacted Files Coverage Δ
app/grants/admin.py 47.05% <ø> (ø)
app/marketing/mails.py 10.81% <0.00%> (-0.11%) ⬇️
app/dashboard/tasks.py 24.82% <15.62%> (-8.10%) ⬇️
app/dashboard/sync/btc.py 17.07% <17.07%> (ø)
app/dashboard/utils.py 41.92% <20.00%> (-0.19%) ⬇️
app/dashboard/views.py 10.50% <20.00%> (+<0.01%) ⬆️
app/dashboard/models.py 49.59% <33.33%> (-0.05%) ⬇️
app/dashboard/search_indexes.py 98.66% <100.00%> (-0.07%) ⬇️
app/marketing/management/commands/post_data.py 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20fe4c8...88d966e. Read the comment docs.

@thelostone-mc
Copy link
Member

@chibie I see commits from your previous PR as well! Could we fix that up?

@thelostone-mc thelostone-mc merged commit daf1a95 into gitcoinco:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants