updates outdated etherscan txn find/replace functionality to use blocknative #7490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
thelostone-mc
approved these changes
Sep 23, 2020
|
Note: need to register BLOCKNATIVE_API key before deploy |
|
its already in the env files in prod!! |
octavioamu
approved these changes
Sep 23, 2020
|
It looks like all these changes have been merged, but my bounty is still pending. Is there something I need to trigger for it to update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updates outdated etherscan txn find/replace functionality to use blocknative
introduces a new function economy.utils.watch_txn() which can be used to tell blocknative to tell us when a txn succeeds, is replaced, or any other number of statuses
deprecates the etherscan getReplacedTX() method that was no lolnger workering due to their new cloudflare integration.
handles the initial work of getting bountyfulfillment txn find/replaces working
Refers/Fixes
like 20% of our CS requests
Testing
tested locally