zkSync UX Improvements #7489
Merged
zkSync UX Improvements #7489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
LGTM! thanks @mds1 :) |
thelostone-mc
approved these changes
Sep 22, 2020
This was referenced Sep 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7397, #7469
Changes
To fix Grants/zkSync checkout: what happens if deposit tx fails? #7397: When the cart loads we check the DB for a deposit tx hash from the user to see if their checkout was interrupted. If it was, we now have a check to see if the transaction failed. If it did fail, we mark the user as "not interrupted" so they can try checking out again
To fix Insufficient DAI balance to complete checkout #7469: During zkSync checkout Flow B (user makes L1 deposit), the zkSync fees were not shown to the user anywhere, so we now show them at the bottom of the modal along with a link to the docs/GRANTS.md file to learn more about fees and how the checkout flow works. The modal is shown in the screenshot below. (Note that we don't need to show these fees in Flow A since the user signs a message containing the fee amount and that wallet should show that message to the user)
cc @willsputra