Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hackathons events #7464

Closed
wants to merge 1 commit into from
Closed

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Sep 18, 2020

Description

image

Refers/Fixes
Testing

@jdorfman
Copy link

jdorfman commented Sep 18, 2020

Looking good @zoek1! Is there a way to add UTM's to the "Join" buttons?

Also, It needs to say "Hackathons" in <h3> centered above so it is clear. I believe it was in the mockup.

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #7464 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7464      +/-   ##
==========================================
+ Coverage   26.18%   26.19%   +0.01%     
==========================================
  Files         307      307              
  Lines       30603    30606       +3     
  Branches     4527     4527              
==========================================
+ Hits         8012     8018       +6     
+ Misses      22317    22314       -3     
  Partials      274      274              
Impacted Files Coverage Δ
app/dashboard/gas_views.py 22.77% <0.00%> (-0.70%) ⬇️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28e142a...72e5c3e. Read the comment docs.

@jdorfman
Copy link

@PixelantDesign @octavioamu this will replace the Disqus widget that has 2+ years of stale content on the gas history page. This page gets a lot of organic search traffic (see GAnalytics) and advertising our current hackathons seems like a better use of space.

@thelostone-mc
Copy link
Member

@zoek1 could we make the code reusable ! I believe we have the exact same format on the hackathon list page
So ideally make that into it's own file and import it in both places

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY code needed

@jdorfman
Copy link

@thelostone-mc will this allow @zoek1 to add custom UTM's so we know where the sign-ups are coming from?

@thelostone-mc
Copy link
Member

thelostone-mc commented Sep 23, 2020

@jdorfman So this would be mapped to the buttons + would be based on the URL from which the users click on them right ?
yeah that's possible even with DRY code

@thelostone-mc thelostone-mc marked this pull request as draft September 23, 2020 10:42
@thelostone-mc
Copy link
Member

@jdorfman closing this out as this code is also present is open in PR https://github.com/gitcoinco/web/pull/7502/commits

@jdorfman
Copy link

Thanks @thelostone-mc !

@jdorfman jdorfman mentioned this pull request Sep 24, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants