Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak validator comments #7453

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Sep 17, 2020

In 044f877 @owocki changed one of the contribution fields to use 18 decimals. The previous value of 4 decimals was causing the tx validator to incorrectly report some txs as failed.

This PR builds on that to just tweak the validator comments so that when they do fail we can get a little bit more info as to why

cc @octavioamu @thelostone-mc

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #7453 into stable will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           stable    #7453   +/-   ##
=======================================
  Coverage   26.17%   26.17%           
=======================================
  Files         307      307           
  Lines       30604    30604           
  Branches     4528     4528           
=======================================
  Hits         8012     8012           
  Misses      22318    22318           
  Partials      274      274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044f877...cf45ad4. Read the comment docs.

@octavioamu octavioamu merged commit 8e2fee0 into gitcoinco:stable Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants