Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small zkSync bugs, run linter #7412

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Fix small zkSync bugs, run linter #7412

merged 1 commit into from
Sep 15, 2020

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Sep 15, 2020

For zkSync Flow A:

  • We were sending too much as amount for first transfer, so zkSync transfers could fail if the total amount held in zkSync was close to the total donation amount
  • Previously we were incorrectly estimating max required signatures for zkSync

Also ran the linter which is the only reason index.js is modified

@mds1
Fix small zkSync bugs, run linter
90751df 
- For zkSync flow A, was sending too much as amount for first transfer
- Was incorrectly estimating max required signatures for zkSync
@octavioamu octavioamu merged commit 1a35d3d into gitcoinco:stable Sep 15, 2020
@baby636 baby636 mentioned this pull request Dec 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlipert danlipert Awaiting requested review from danlipert

@frankchen07 frankchen07 Awaiting requested review from frankchen07

@octavioamu octavioamu Awaiting requested review from octavioamu

@PixelantDesign PixelantDesign Awaiting requested review from PixelantDesign

@thelostone-mc thelostone-mc Awaiting requested review from thelostone-mc thelostone-mc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mds1 @octavioamu