Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show edit and add instruction to verifiy account #7405

Merged
merged 2 commits into from
Sep 15, 2020

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Sep 15, 2020

Description

image

Refers/Fixes

#7380
#7385
#7389
#7390
#7392

#7399
#7396

Testing

@zoek1 zoek1 changed the base branch from master to stable September 15, 2020 16:53
@zoek1 zoek1 changed the base branch from stable to master September 15, 2020 16:54
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #7405 into stable will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #7405      +/-   ##
==========================================
+ Coverage   26.27%   26.30%   +0.03%     
==========================================
  Files         306      306              
  Lines       30455    30433      -22     
  Branches     4501     4494       -7     
==========================================
+ Hits         8001     8005       +4     
+ Misses      22180    22154      -26     
  Partials      274      274              
Impacted Files Coverage Δ
app/grants/views.py 14.54% <0.00%> (+0.20%) ⬆️
app/grants/models.py 42.70% <0.00%> (-0.05%) ⬇️
app/grants/clr.py 0.00% <0.00%> (ø)
app/grants/admin.py 47.05% <0.00%> (ø)
...perftools/management/commands/create_page_cache.py 0.00% <0.00%> (ø)
app/dashboard/views.py 10.49% <0.00%> (+<0.01%) ⬆️
app/grants/tasks.py 18.75% <0.00%> (+0.32%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5858b48...41676b4. Read the comment docs.

@zoek1 zoek1 force-pushed the hotfix/twitter-edit branch from 5907a52 to 8556335 Compare September 15, 2020 17:05
@zoek1 zoek1 changed the base branch from master to stable September 15, 2020 17:05
@octavioamu octavioamu merged commit ee84ed4 into gitcoinco:stable Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants