Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tribe v2 #7350

Merged
merged 6 commits into from
Sep 23, 2020
Merged

Feature/tribe v2 #7350

merged 6 commits into from
Sep 23, 2020

Conversation

sanchaymittal
Copy link
Contributor

@sanchaymittal sanchaymittal commented Sep 10, 2020

Description
  1. Gitcoin staff can edit header view of tribes
  • With this tribe header can be edited by gitcoin staff now.
  1. Ordered User profile & Townsquare side-bar UI
  • Allows to fetch correct ordering of user profile based on rank_coder
  • sidebar UI elements will now show name only.
  • before it was showing followers count only.
Refers/Fixes

#7310
#7295

Testing

https://www.loom.com/share/56038d60ecf34d3aadf6e3980c2f5fd3

- with this tribe header can be edited by gitcoin staff now.
- Alllows to fetch correct ordering of user profile based on rank_coder
- sidebar ui elements will now show name only.
- before it was showing followers count.
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #7350 into master will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7350      +/-   ##
==========================================
+ Coverage   26.16%   26.47%   +0.31%     
==========================================
  Files         307      303       -4     
  Lines       30630    29997     -633     
  Branches     4533     4430     -103     
==========================================
- Hits         8014     7943      -71     
+ Misses      22342    21784     -558     
+ Partials      274      270       -4     
Impacted Files Coverage Δ
app/dashboard/views.py 10.48% <100.00%> (-0.03%) ⬇️
app/grants/utils.py 21.05% <0.00%> (-3.05%) ⬇️
app/marketing/admin.py 84.41% <0.00%> (-0.59%) ⬇️
app/retail/views.py 20.45% <0.00%> (-0.31%) ⬇️
app/marketing/models.py 65.00% <0.00%> (-0.27%) ⬇️
app/kudos/models.py 50.62% <0.00%> (-0.16%) ⬇️
app/townsquare/models.py 57.95% <0.00%> (-0.11%) ⬇️
app/marketing/views.py 11.90% <0.00%> (-0.06%) ⬇️
app/app/settings.py 82.55% <0.00%> (-0.06%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5808814...344e3b9. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

app/assets/v2/js/vue-components.js Outdated Show resolved Hide resolved
app/assets/v2/js/users.js Outdated Show resolved Hide resolved
@thelostone-mc thelostone-mc merged commit 9ffc13a into master Sep 23, 2020
@thelostone-mc thelostone-mc deleted the feature/tribe-v2 branch October 6, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants