Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix margins on roundup #7335

Merged
merged 1 commit into from
Sep 4, 2020
Merged

fix margins on roundup #7335

merged 1 commit into from
Sep 4, 2020

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Sep 4, 2020

Copy link

@jdorfman jdorfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked video, LGTM

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #7335 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7335      +/-   ##
==========================================
+ Coverage   26.47%   26.49%   +0.02%     
==========================================
  Files         303      303              
  Lines       29996    29996              
  Branches     4430     4430              
==========================================
+ Hits         7942     7948       +6     
+ Misses      21779    21778       -1     
+ Partials      275      270       -5     
Impacted Files Coverage Δ
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.45% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903f393...e6c40ab. Read the comment docs.

@thelostone-mc thelostone-mc merged commit ba34f93 into gitcoinco:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants