Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trust Bonus Tab With BrightID Integration #7333
Add Trust Bonus Tab With BrightID Integration #7333
Changes from all commits
afafe38
d1593f9
69bd515
5f2a4f0
5f598c4
b12fe94
79f4c01
44307b4
92dd30b
6fd6f85
e3220a6
ff8e515
c48493c
f8f6028
e1919f3
e26b3c9
a0cf0e6
1cf5495
72c552d
0b59c28
515c552
3f6ed76
a407d25
ec30a52
8611a19
de0265c
0d54c77
776c5f7
3b7e315
edcab71
5c2d610
84384ff
ce57735
19654b5
59e5d5a
a2b6cae
4a95483
bbe2f1a
55b084c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoded limit is gonna get us in trtouble in prod where there are 40k profiles
also whats the plan for new profiles, how are they going to get a brightid uuid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it would be auto-assigned one on creation which is unique (as defined in the model)
Is my understanding right @apbendi ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if I've done this right, a new UUID should be generated when a user is created, per this migration:
https://github.com/gitcoinco/web/pull/7333/files#diff-f2afa72d3c42b2cac75651dd47a6c961R14
Can you sanity check that looks correct.
I'm not sure about the 1K limit @thelostone-mc, why did you have that in there? Did it take 2 minutes to run for only 1K records or for the full 40K?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 min for the whole 40k !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frank this is what we are using
https://github.com/gitcoinco/web/pull/7288/files#r485161296