Display # of notif, grants and chats #7315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoek1
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
|
same questions as Alisa, one by one, does it keep the count? clearing it looks good though. another use case is if I read 1-2 messages, and then get 3-4 more. Just want to make sure the count is robust in all situations. |
|
has the video been updated? or is it the same one? |
|
not sure what is the problem, I didn't touch any python code. Just js and html changes :P |
thelostone-mc
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://www.loom.com/share/aca792e75ccf4bb9abf6029064b75448
Read one by one updates in real time.
https://www.loom.com/share/6a1a2073d3fa4629850f615f5d2ed90f
Refers/Fixes
#7258
Testing