-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated user directory models/indexers to reflect proper production d… #7307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@androolloyd could you create a new migration instead updating the old one
This has already been run on live
Since we’re not managing the migrations with django it won’t affect anything, while the migration execution status is stored in the db as being called. No SQL is executed by it. These changes are to bring the python model in line with what’s actually being produced by prod data. I can create a migration that modifies the view but if we have an execution status already for this migration there isn’t a need to run anything again anyways. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synced up with @androolloyd who's assured like the migrations files are not bring tracked and has no affect on the rest of the app.
Updating the migration file should be alright even though it's already in live
…rectory-column-updates
Codecov Report
@@ Coverage Diff @@
## stable #7307 +/- ##
=======================================
Coverage 26.50% 26.50%
=======================================
Files 301 301
Lines 29917 29919 +2
Branches 4416 4416
=======================================
+ Hits 7929 7931 +2
Misses 21711 21711
Partials 277 277
Continue to review full report at Codecov.
|
Description
Correct the UserDirectory Model and Indexers are not configured with correct types/schema requirements to match what is used in production
Refers/Fixes
Inability to index the current userdirectory
Testing