Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated user directory models/indexers to reflect proper production d… #7307

Merged
merged 5 commits into from
Sep 4, 2020

Conversation

androolloyd
Copy link
Contributor

@androolloyd androolloyd commented Aug 31, 2020

Description

Correct the UserDirectory Model and Indexers are not configured with correct types/schema requirements to match what is used in production

Refers/Fixes

Inability to index the current userdirectory

Testing

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@androolloyd could you create a new migration instead updating the old one
This has already been run on live

@androolloyd
Copy link
Contributor Author

Since we’re not managing the migrations with django it won’t affect anything, while the migration execution status is stored in the db as being called.

No SQL is executed by it.

These changes are to bring the python model in line with what’s actually being produced by prod data.

I can create a migration that modifies the view but if we have an execution status already for this migration there isn’t a need to run anything again anyways.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced up with @androolloyd who's assured like the migrations files are not bring tracked and has no affect on the rest of the app.
Updating the migration file should be alright even though it's already in live

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #7307 into stable will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           stable    #7307   +/-   ##
=======================================
  Coverage   26.50%   26.50%           
=======================================
  Files         301      301           
  Lines       29917    29919    +2     
  Branches     4416     4416           
=======================================
+ Hits         7929     7931    +2     
  Misses      21711    21711           
  Partials      277      277           
Impacted Files Coverage Δ
app/dashboard/models.py 49.80% <100.00%> (+0.01%) ⬆️
app/dashboard/search_indexes.py 98.73% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e4379...4fbbc45. Read the comment docs.

@thelostone-mc thelostone-mc changed the base branch from stable to master September 4, 2020 14:28
@thelostone-mc thelostone-mc changed the base branch from master to stable September 4, 2020 14:42
@thelostone-mc thelostone-mc merged commit 1a3ad34 into stable Sep 4, 2020
@walidmujahid walidmujahid mentioned this pull request Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants