Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple winners #7302

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Allow multiple winners #7302

merged 4 commits into from
Oct 14, 2020

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Aug 31, 2020

Description
  • Remove restriction to unselect previous winner when other submission is marked as winner
  • Ensure these project winners are marked as winners in the project tab at the hackathon view
  • Remove option to mark winners from the projects tab

https://www.loom.com/share/2933178142c34bdb9b5a59de0515f35c

Refers/Fixes

#7281

Testing

@zoek1 zoek1 changed the title Allow multiple submissions Allow multiple winners Aug 31, 2020
frankchen07
frankchen07 approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@frankchen07 frankchen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Around the 0:15 mark of the video, you selected none for the winners, but on the Brave Browser, there still was one winner. Was this because you didn't refresh?

@thelostone-mc
Copy link
Member

thelostone-mc commented Sep 17, 2020 •
edited
Loading

@zoek1 is this good for merge / do we need to update something on this?

@thelostone-mc
Copy link
Member

Closing as this in present in https://github.com/gitcoinco/web/pull/7309/commits

@PixelantDesign PixelantDesign reopened this Oct 7, 2020
@chibie chibie self-requested a review October 14, 2020 13:42
@thelostone-mc thelostone-mc merged commit 0c495b5 into gitcoinco:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankchen07 frankchen07 frankchen07 approved these changes

@chibie chibie chibie approved these changes

@octavioamu octavioamu octavioamu approved these changes

@PixelantDesign PixelantDesign PixelantDesign approved these changes

@danlipert danlipert Awaiting requested review from danlipert

@thelostone-mc thelostone-mc Awaiting requested review from thelostone-mc thelostone-mc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zoek1 @thelostone-mc @PixelantDesign @octavioamu @chibie @frankchen07