Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Link to repo on Grant Detail info #7301

Merged
merged 10 commits into from
Sep 1, 2020
Merged

Add Github Link to repo on Grant Detail info #7301

merged 10 commits into from
Sep 1, 2020

Conversation

molecula451
Copy link
Contributor

@molecula451 molecula451 commented Aug 30, 2020

Description

This PR will optionally request github link repo on the grants new form and append it to the grant details info for the looks

Screencast-2020-08-30-124937

Refers/Fixes

fix #7270

Testing

@molecula451 molecula451 changed the title Add Github Link to repo on Grant info Add Github Link to repo on Grant Detail info Aug 30, 2020
@molecula451 molecula451 marked this pull request as ready for review August 30, 2020 17:45
@@ -101,6 +101,18 @@ <h1 class="font-title-xl my-4 font-weight-bold">
</p>
</div>
{% endif %}

{% if grant.github_project_url %}
Copy link
Member

@thelostone-mc thelostone-mc Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deindent this by 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

de-indented.

{{ grant.github_project_url }}
</a>
</p>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent this by 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indented.

@thelostone-mc
Copy link
Member

@molecula451 looks good except for the indentation!Could you fix that up ?

@molecula451
Copy link
Contributor Author

@molecula451 looks good except for the indentation!Could you fix that up ?

yup. fixed :)

@thelostone-mc thelostone-mc merged commit 6ee3898 into gitcoinco:master Sep 1, 2020
thelostone-mc added a commit that referenced this pull request Sep 17, 2020
admin for #7301

Co-authored-by: Aditya Anand M C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grants - - there should be a github link to their repo on the grantdetail page
2 participants