Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing JSONStore object #7285

Conversation

walidmujahid
Copy link
Contributor

related to recent PR #7254

prevent error in local docker builds due to non-existing JSONStore object by automatically calling create_hackathon_list_page_cache from the get_hackathons view if debug is on.

@walidmujahid walidmujahid force-pushed the quick-fix-jsonstore-object-for-local-builds branch from 9622aae to 2858ff8 Compare August 25, 2020 18:15
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #7285 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7285      +/-   ##
==========================================
+ Coverage   26.10%   26.12%   +0.01%     
==========================================
  Files         300      300              
  Lines       29698    29701       +3     
  Branches     4409     4410       +1     
==========================================
+ Hits         7752     7758       +6     
+ Misses      21674    21671       -3     
  Partials      272      272              
Impacted Files Coverage Δ
app/dashboard/views.py 10.42% <0.00%> (-0.02%) ⬇️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8678da...36c0630. Read the comment docs.

@thelostone-mc thelostone-mc merged commit d3b4215 into gitcoinco:master Aug 27, 2020
@thelostone-mc
Copy link
Member

Thanks @walidmujahid ! ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants