Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pay higher gas price, wait longer to issue kudos #7265

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

danlipert
Copy link
Contributor

Description

This PR raises the amount we are willing to pay for gas, allows a 5 hour window for kudos sending transactions to be confirmed to attempt to get a better gas price, waits longer between rechecking gas prices for a kudos send, and rate limits the kudos sending task.

Refers/Fixes

n/a

Testing

untested - needs to be deployed and then monitored via flower

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #7265 into master will increase coverage by 2.13%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7265      +/-   ##
==========================================
+ Coverage   26.08%   28.22%   +2.13%     
==========================================
  Files         297      298       +1     
  Lines       29539    32232    +2693     
  Branches     4386     5160     +774     
==========================================
+ Hits         7706     9097    +1391     
- Misses      21562    22778    +1216     
- Partials      271      357      +86     
Impacted Files Coverage Δ
app/kudos/tasks.py 28.94% <50.00%> (ø)
app/app/urls.py 79.10% <0.00%> (-6.87%) ⬇️
...arketing/management/commands/new_bounties_email.py 40.50% <0.00%> (-4.57%) ⬇️
app/quests/views.py 16.22% <0.00%> (ø)
app/dashboard/views.py 10.33% <0.00%> (ø)
app/economy/management/commands/get_prices.py 0.00% <0.00%> (ø)
app/grants/management/commands/estimate_clr.py 0.00% <0.00%> (ø)
app/marketing/management/commands/post_data.py 0.00% <0.00%> (ø)
...rants/management/commands/grant_vitalik_shuffle.py 0.00% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b96ece1...ac65012. Read the comment docs.

@thelostone-mc thelostone-mc changed the base branch from master to stable August 21, 2020 13:41
@thelostone-mc thelostone-mc merged commit ac0b962 into stable Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants