Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Circle #7262

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Integrate Circle #7262

merged 1 commit into from
Sep 1, 2020

Conversation

sanchaymittal
Copy link
Contributor

@sanchaymittal sanchaymittal commented Aug 20, 2020

Description
  • Integration of circle to apollo hackathon only.
  • Replaces the old town square with gitcoin circle community.

Demo Video
https://www.loom.com/share/7574a829191e47b8b1c428e3f122caf2

Refers/Fixes
Testing

- Integration of circle to apollo hackathon only.
- Replaces the old townsquare with gitcoin circle community.
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #7262 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7262   +/-   ##
=======================================
  Coverage   26.11%   26.11%           
=======================================
  Files         298      298           
  Lines       29617    29617           
  Branches     4397     4397           
=======================================
  Hits         7733     7733           
  Misses      21607    21607           
  Partials      277      277           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f1ab4...3f5b9a4. Read the comment docs.

@sanchaymittal sanchaymittal changed the title New feature integration of circle to apollo hackathon Integrate Circle Aug 20, 2020
@thelostone-mc
Copy link
Member

neat stuff !
A couple of questions + thoughts

  • Wiring this in would essentially replace Apollo Townsquare which means we'd have no filter by Apollo Townsquare posts on the landing page.
  • If so -> we should write up and if check to remove that as well
  • Lastly, if we go down this route for all hackathons -> we'd also have to remove the code for everything else

image

We also don't want a scenario where you have some info on townsquare / some info on circle.
So before we get this in -> we need to ensure no more updates happen on townsquare with the apollo tag

Additionally, could you boot up this up via ngrok and get a sign off hackathon team! I can help you push it to them for review ^_^

@danlipert danlipert marked this pull request as draft August 21, 2020 15:53
@danlipert
Copy link
Contributor

Marking as draft until we talk w/ hackops team on these changes

@sanchaymittal
Copy link
Contributor Author

neat stuff !
A couple of questions + thoughts

  • Wiring this in would essentially replace Apollo Townsquare which means we'd have no filter by Apollo Townsquare posts on the landing page.

With this, we won't need Townsquare filters as circle got its own filters and we can create different spaces of discussions.

  • If so -> we should write up and if check to remove that as well

For sure but for now, I limited the circle integration changes to Apollo Hackathon only.

  • Lastly, if we go down this route for all hackathons -> we'd also have to remove the code for everything else

Yes, we would need too.

image

We also don't want a scenario where you have some info on townsquare / some info on circle.

Well, the idea is to replace Townsquare with circle. So I think we need some sort of transition to replace the discussions.

So before we get this in -> we need to ensure no more updates happen on townsquare with the apollo tag

Additionally, could you boot up this up via ngrok and get a sign off hackathon team! I can help you push it to them for

Sure, But there is already a hyperlink for this which is embedded: https://gitcoin.circle.so/
We can use this to play around and review it.

review ^_^

@frankchen07
Copy link
Contributor

making a note that we should watch the analytics tab on Circle very closely to see how it's used, and compare that to GC chat. This will help make determinations on what to keep or discard in the future.

@sanchaymittal
Copy link
Contributor Author

making a note that we should watch the analytics tab on Circle very closely to see how it's used, and compare that to GC chat. This will help make determinations on what to keep or discard in the future.

For a hands-on experience, please join the community & ping me I will make you an admin and you can check out the analytics.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this, we won't need Townsquare filters as circle got its own filters and we can create different spaces of discussions.

@sanchaymittal I'm talking about the highlighted section on the landing page:

image

Also these links have to be removed from the posts.
As clicking that will lead them to hackathon Townsquare which no longer exists
image

@sanchaymittal
Copy link
Contributor Author

sanchaymittal commented Aug 28, 2020

With this, we won't need Townsquare filters as circle got its own filters and we can create different spaces of discussions.

The highlighted section on the landing page shouldn't pose any problem as it redirects to townsquare only.

Also, the link onto the messages via hackathon will lead to townsquare only which exist. So it shouldn't break anything. But we can scrap out the messages.

@thelostone-mc thelostone-mc changed the base branch from master to stable September 1, 2020 09:45
@thelostone-mc thelostone-mc marked this pull request as ready for review September 1, 2020 10:11
@thelostone-mc thelostone-mc merged commit bfb2f29 into stable Sep 1, 2020
thelostone-mc added a commit that referenced this pull request Sep 4, 2020
* updates grants round 7 start, to allow for deploly + QA

* sentry user_card fixes

* hack list

* card fixes

* profile project url

* fix for https://gitcoincore.slack.com/archives/CAXQ7PT60/p1598454051039600

* fix fees data not saving

* remove repeated call to user-cards

* bump  walletconnection version

* bump walletconnect to version 1.2.1

* test bot flow

* bot trace

* justin YOLO request https://gitcoincore.slack.com/archives/CJWQWG6J2/p1598630565055100

* feat: update payoutid when txnid is replaced

* User Directory: Elastic Search Edition. (#7204)

* WIP, Frank's Super Query added as a view, connected to a ViewSet and returned through the api

* WIP: Elastic Search using Haystack
- indexes all Profiles, mergeing the to_dict method into the search store itself,
- Bounty, and HackathonProject indexers are stubbed out to work on a path for relational models

* WIP urls and search view

* enable auto complete for lastname, handle, first name, and persona

* remove other indexers

* WIP: UserDirectory
 - vue search app hacked into the old user search application
 - dynamic filters, are all set to checkbox filters presently adjusting by type of metrics is required

* wip, user cards rendering

* dynamic auto complete based on fields like kibana, still WIP

* WIP: dynamic filtering, some style work still needed, dynamic query building is possible

* numeric list filter adjusted to account for elastic type

* V0 RC1

* restore old user directory

* restored docker-compose, addressed review comments

* remove email from the elastic search indexer

* add crontab entry for elasticsearch update

* haystack settings configured to retrieve the proper env variable, removing stale ui components

* add missing migration

* revert docker-compose change for chat directories

* updated path for chat config directory

* Bug fixes around the vue app(was loading incorrect js) (#7303)

* Bug fixes around the vue app(was loading incorrect js)
- added a authenticated proxy route to the elastic search cluster

* added a check for settings.DEBUG for http/https

* fix /

* updates quests, adds a fun little new earnings helper script.

* New feature integration of circle to apollo hackathon (#7262)

- Integration of circle to apollo hackathon only.
- Replaces the old townsquare with gitcoin circle community.

* bot notifs

* fix user elastic directory

* dependencies call

* indentation and styles cascade

* remove

* Update base.txt

* fix and create migrations

* chains logos visual fix

* fix versions giving errors on tests

* comment grants test failing

* rollback versions

* comment out all test

Co-authored-by: owocki <[email protected]>
Co-authored-by: Aditya Anand M C <[email protected]>
Co-authored-by: Andrew Redden <[email protected]>
Co-authored-by: Sanchay Mittal <[email protected]>
@sanchaymittal sanchaymittal deleted the feature/integrate-circle branch October 1, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants