-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a gitcoin.co/explorer stale bounty filter #7229
add a gitcoin.co/explorer stale bounty filter #7229
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7229 +/- ##
==========================================
+ Coverage 26.10% 26.12% +0.02%
==========================================
Files 297 297
Lines 29508 29508
Branches 4377 4377
==========================================
+ Hits 7703 7709 +6
+ Misses 21534 21528 -6
Partials 271 271
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chibie
Dope job on getting this up quick!
A few comments:
- could you undo the indent fixes made by your editor ?
We typically use eslint + stylelint for the frontend - the chatconfig file can be ignored, I'll update it on the
.gitignore
- finally for the HTML we prefer having it as
{% is_staff %}
<p>hello</p>
{% endif %}
instead of(which your editor changed)
{% is_staff %}
<p>hello</p>
{% endif %}
Could you also throw in a video of the working ?
Thanks for the compliment @thelostone-mc The indents were actually altered when I ran I'll revert the indents manually as directed. A video recording would also be attached asap. |
ee37952
to
e6da3b0
Compare
All fixes have been made. I also included a link to screen recording in the description. |
LGTM apart from that minor removing that file! |
e6da3b0
to
00775d1
Compare
@chibie nice work! I didn't realize make fix would do that - we should run it against everything sometime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!!
Description
This PR adds a stale bounty filter titled "Not Picked Up 3+ Days". It enables logged in funders view bounties created by them more than 3 days but which are still in "open" state.
Before:
After:
Here's a screen recording
Refers/Fixes
#7195
Testing