Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a gitcoin.co/explorer stale bounty filter #7229

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Aug 13, 2020

Description

This PR adds a stale bounty filter titled "Not Picked Up 3+ Days". It enables logged in funders view bounties created by them more than 3 days but which are still in "open" state.

Before:

Screenshot 2020-08-13 at 03 35 44

After:

bounties

Here's a screen recording

Refers/Fixes

#7195

Testing

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #7229 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7229      +/-   ##
==========================================
+ Coverage   26.10%   26.12%   +0.02%     
==========================================
  Files         297      297              
  Lines       29508    29508              
  Branches     4377     4377              
==========================================
+ Hits         7703     7709       +6     
+ Misses      21534    21528       -6     
  Partials      271      271              
Impacted Files Coverage Δ
app/app/urls.py 85.96% <ø> (ø)
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a892f10...00775d1. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chibie

Dope job on getting this up quick!

A few comments:

  • could you undo the indent fixes made by your editor ?
    We typically use eslint + stylelint for the frontend
  • the chatconfig file can be ignored, I'll update it on the .gitignore
  • finally for the HTML we prefer having it as
{% is_staff %}
  <p>hello</p>
{% endif %}

instead of(which your editor changed)

{% is_staff %}
<p>hello</p>
{% endif %}

Could you also throw in a video of the working ?

@chibie
Copy link
Contributor Author

chibie commented Aug 13, 2020

Thanks for the compliment @thelostone-mc

The indents were actually altered when I ran make fix as specified in the contributing guide.

I'll revert the indents manually as directed.

A video recording would also be attached asap.

@chibie chibie force-pushed the feature/stale-bounty-filter branch from ee37952 to e6da3b0 Compare August 13, 2020 15:09
@chibie
Copy link
Contributor Author

chibie commented Aug 13, 2020

Hi @thelostone-mc

All fixes have been made.

I also included a link to screen recording in the description.

@chibie chibie requested a review from thelostone-mc August 13, 2020 15:19
@thelostone-mc
Copy link
Member

LGTM apart from that minor removing that file!

@chibie chibie force-pushed the feature/stale-bounty-filter branch from e6da3b0 to 00775d1 Compare August 14, 2020 12:40
@chibie chibie requested a review from thelostone-mc August 14, 2020 12:40
@danlipert
Copy link
Contributor

@chibie nice work! I didn't realize make fix would do that - we should run it against everything sometime

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!!

@thelostone-mc thelostone-mc merged commit 808b6d3 into gitcoinco:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants