Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added badges #7226

Merged
merged 4 commits into from
Aug 19, 2020
Merged

added badges #7226

merged 4 commits into from
Aug 19, 2020

Conversation

3scava1i3r
Copy link
Contributor

Description

added badges for better visualization and better social media reach
and deleted the non responsive image at the end of the README.md file

Refers/Fixes

#7225

Testing

Readme file edit would not need testing right?

 for better visualization and better social media reach
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #7226 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7226      +/-   ##
==========================================
+ Coverage   26.10%   26.12%   +0.02%     
==========================================
  Files         297      297              
  Lines       29508    29508              
  Branches     4377     4377              
==========================================
+ Hits         7703     7709       +6     
+ Misses      21534    21528       -6     
  Partials      271      271              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b8140f...fd9857e. Read the comment docs.

@@ -211,6 +237,3 @@ Note:

- [Code - GNU AFFERO GENERAL PUBLIC LICENSE](../LICENSE)
- [Creative assets -- Attribution-NonCommercial-NoDerivatives 4.0 International](../app/assets/LICENSE.txt)

<!-- Google Analytics -->
<img src='https://ga-beacon.appspot.com/UA-102304388-1/gitcoinco/web' style='width:1px; height:1px;' >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image is no longer available and shows a dead link so please find and alternative but till then i removed it

@danlipert danlipert marked this pull request as draft August 12, 2020 12:12
@3scava1i3r 3scava1i3r marked this pull request as ready for review August 14, 2020 05:53
@thelostone-mc thelostone-mc merged commit 82f431a into gitcoinco:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants