Kudos Claim timer not updating dom on completion #7214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…im Kudos page with gas required timer
anoof
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7214 +/- ##
==========================================
+ Coverage 26.18% 26.20% +0.02%
==========================================
Files 297 297
Lines 29390 29390
Branches 4343 4343
==========================================
+ Hits 7696 7702 +6
+ Misses 21423 21417 -6
Partials 271 271
Continue to review full report at Codecov.
|
|
Could you throw in a video of it @anoof ? |
|
@thelostone-mc I've attached a gif:
|
danlipert
approved these changes
Aug 12, 2020
thelostone-mc
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Claim Kudos page with required gas is not re-enabling the button and updating dom when the timer ends, after completing any quest. Refer #7177.
Refers/Fixes
closes #7177
Testing
Done manual testing on local setup using generated Kudos with paid_until variable set.
screen: