Personal Tokens #7212
Personal Tokens #7212
Conversation
* Setup ptokens and add pages * Update link * Update links * Add dashboard route * Update buy tokens disclaimer to italics * Add disclaimer text to quickstart * Made css fixes * Update faq link
|
Interesting, let me know! We didn't change |
|
@mds1 I've fixed it up on master !
|
app/assets/v2/js/user_card.js
Outdated
| if (data.profile.has_ptoken) { | ||
| mount_graph = [ tips_total_percent, token_total_percent, bounties_total_percent, grants_total_percent ]; | ||
| } else { | ||
| mount_graph = [ tips_total_percent, bounties_total_percent, grants_total_percent ]; | ||
| } |
There was a problem hiding this comment.
maybe something more cleaner like
if (data.profile.has_ptoken) { mount_graph.push(token_total_percent) }
There was a problem hiding this comment.
I'll defer to @zoek1 on this one
| @@ -62,7 +62,7 @@ def handle(self, *args, **options): | |||
| network = 'mainnet' if not settings.DEBUG else 'rinkeby' | |||
| from_address = settings.MINICLR_ADDRESS | |||
| from_pk = settings.MINICLR_PRIVATE_KEY | |||
| DAI_ADDRESS = '0x6b175474e89094c44da98b954eedeac495271d0f' if network=='mainnet' else '0x6A9865aDE2B6207dAAC49f8bCba9705dEB0B0e6D' | |||
| DAI_ADDRESS = '0x6b175474e89094c44da98b954eedeac495271d0f' if network=='mainnet' else '0x5592EC0cfb4dbc12D3aB100b257153436a1f0FEa' | |||
There was a problem hiding this comment.
^ Was this update intended ?
There was a problem hiding this comment.
Yea this was intended.
The first address 0x6A9865aDE2B6207dAAC49f8bCba9705dEB0B0e6D is the official Rinkeby DAI address. But Oasis on Rinkeby has been down for a while now, so it's very difficult to mint DAI on RInkeby.
We switched to 0x5592EC0cfb4dbc12D3aB100b257153436a1f0FEa, which is the address for Rinkeby DAI given out when using the faucet available on https://app.compound.finance/. This makes it a lot easier to get Rinkeby DAI for development/testing
| @@ -213,7 +213,7 @@ | |||
| "real_period_seconds": "2592000", | |||
| "frequency_unit": "days", | |||
| "frequency": "30", | |||
| "token_address": "0x6A9865aDE2B6207dAAC49f8bCba9705dEB0B0e6D", | |||
| "token_address": "0x5592EC0cfb4dbc12D3aB100b257153436a1f0FEa", | |||
| "token_symbol": "DAI", | |||
| "gas_price": "25000.0000", | |||
| "new_approve_tx_id": "0x980ce738853f454c83d5551dc086a29d2d89781fb041a9ce581474ffdf639de4", | |||
There was a problem hiding this comment.
^ could we undo all these changes
There was a problem hiding this comment.
See above comment #7212 (comment) — I think we should keep these changes.
|
Hey @thelostone-mc and @octavioamu — just add one more commit which updates the Terms of Service to add a new section based on what @owocki provided. Section 12 is the new section. Can you quickly review to confirm that all re-numberings of sections 13 through 30 were done properly? Just want to make sure there's none I missed. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #7212 +/- ##
==========================================
+ Coverage 26.00% 26.51% +0.51%
==========================================
Files 310 311 +1
Lines 31226 30724 -502
Branches 4622 4546 -76
==========================================
+ Hits 8119 8146 +27
+ Misses 22828 22299 -529
Partials 279 279
Continue to review full report at Codecov.
|
Description
The merge of all things Gitcoin personal tokens.
Refers/Fixes
This adds the ability for one to create a personal token, and for other Gitcoin members to purchase and redeem those tokens for one's time.
Testing
Running QA document here: https://hackmd.io/K3DRZVwCSsuneF29wdCxvg?view