proactively stop retrying tasks before max retries exception #7207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlipert
requested review from
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7207 +/- ##
==========================================
- Coverage 26.18% 26.18% -0.01%
==========================================
Files 297 297
Lines 29375 29377 +2
Branches 4339 4340 +1
==========================================
Hits 7693 7693
+ Misses 21411 21408 -3
- Partials 271 276 +5
Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
Aug 10, 2020
owocki
reviewed
Aug 10, 2020
| @@ -36,7 +36,7 @@ def mint_token_request(self, token_req_id, retry=False): | |||
| obj = TokenRequest.objects.get(pk=token_req_id) | |||
| multiplier = 1 | |||
| gas_price = int(float(recommend_min_gas_price_to_confirm_in_time(1)) * multiplier) | |||
| if gas_price > delay_if_gas_prices_gt_mint: | |||
| if gas_price > delay_if_gas_prices_gt_mint and self.request.retries < self.max_retries: | |||
There was a problem hiding this comment.
wont this LOC do more retries now that you've removed the self.request.retries < self.max_retries condition? now it will infinitely retry, if im reading it right.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR stops exceptions that are thrown when minting or redeeming airdropped kudos, either due to network congestion or some other reason that causes the celery task to be retried. After the max retries are hit, we stop attempting to retry to the task.
Refers/Fixes
n/a
Testing
untested