Add question restrictions to polls #7206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/add-question-restrictions
zoek1
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7206 +/- ##
==========================================
+ Coverage 26.18% 26.20% +0.02%
==========================================
Files 297 297
Lines 29385 29390 +5
Branches 4342 4343 +1
==========================================
+ Hits 7694 7702 +8
+ Misses 21420 21417 -3
Partials 271 271
Continue to review full report at Codecov.
|
danlipert
approved these changes
Aug 10, 2020
app/dashboard/models.py
Outdated
| @@ -5191,6 +5191,10 @@ class Question(SuperModel): | |||
| ('OPEN', 'Open'), | |||
| ) | |||
|
|
|||
| TYPE_RESTRICTIONS = ( | |||
There was a problem hiding this comment.
removed, thanks @thelostone-mc :)
|
minimum character count for open questions looks good Can you show the functionality of where we can toggle each question on or off for the restriction? otherwise LGTM |
PixelantDesign
approved these changes
Aug 11, 2020
frankchen07
approved these changes
Aug 11, 2020
octavioamu
approved these changes
Aug 11, 2020
|
yayyyy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://www.loom.com/share/3ccdcc43a69d42c387481be328dddb29
Refers/Fixes
closes #7181
Testing