Update tip page to auto calculate USD #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
omg this is awesome |
owocki
reviewed
Dec 4, 2017
| } | ||
|
|
||
| var amount = jQuery("input[name=amount]").val(); | ||
| var denomination = "ETH"; |
There was a problem hiding this comment.
any way to make the module correctly handle non-ETH tips
hint: if metamask is on the mainnet, a bunch of diff ERC20 tokens will show
There was a problem hiding this comment.
oh shoot i just realized the 'new bounty' page doesnt really handle this correctly eeither
There was a problem hiding this comment.
per slack convo im gonna merge your PR and create a new bounty for ERC20 token compatibility
ethikz
pushed a commit
to ethikz/web
that referenced
this pull request
Jan 24, 2018
Update tip page to auto calculate USD
owocki
pushed a commit
that referenced
this pull request
Apr 30, 2021
leaderboard thegraph implementation + faq linkable hash / collapsable upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fulfill #53 by implementing approx USD display following tip ETH amount.
I'm not a big frontend person, so bare with the PR. I'll submit revisions where necessary, but it calculates as requested.