bug: fix ERC-20 payment flow #7198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
requested review from
danlipert,
frankchen07,
octavioamu and
PixelantDesign
as code owners
octavioamu
reviewed
Aug 6, 2020
| from: selectedAccount, | ||
| value: web3.utils.toWei(String(amount)), | ||
| gasPrice: web3.utils.toHex(5 * Math.pow(10, 9)), | ||
| gas: web3.utils.toHex(318730), |
There was a problem hiding this comment.
do we want to pass the gas amount or let metamask ?
There was a problem hiding this comment.
Oh that is for the ETH flow! We can raise a follow up PR to take care of that ?
There was a problem hiding this comment.
hmm yeah was this just a relic of the gas needed for std bounties registration?
danlipert
approved these changes
Aug 6, 2020
octavioamu
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description + Test
Flows tested
https://gitcoincore.slack.com/archives/CAXQ7PT60/p1596709635067100?thread_ts=1596666404.051500&cid=CAXQ7PT60
cc @octavioamu could you validate it