remove duplicate env key ETHERSCAN_API_KEY
#7184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walidmujahid
requested review from
danlipert,
frankchen07,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7184 +/- ##
==========================================
+ Coverage 26.19% 26.20% +0.01%
==========================================
Files 297 297
Lines 29376 29375 -1
Branches 4339 4339
==========================================
+ Hits 7695 7699 +4
+ Misses 21410 21405 -5
Partials 271 271
Continue to review full report at Codecov.
|
walidmujahid
changed the title
ETHERSCAN_API_KEYETHERSCAN_API_KEY
| @@ -577,9 +577,6 @@ def callback(request): | |||
| GITHUB_API_TOKEN = env('GITHUB_API_TOKEN', default='') # TODO | |||
| GITHUB_APP_NAME = env('GITHUB_APP_NAME', default='gitcoin-local') | |||
|
|
|||
| # Etherscan API | |||
| ETHERSCAN_API_KEY = env('ETHERSCAN_API_KEY', default='') | |||
There was a problem hiding this comment.
Is this duplicated as well? I couldn't find it
There was a problem hiding this comment.
@thelostone-mc That was the original line, however, PR #6940 added the duplicate to line 56, so I removed the original from L581 and kept then one from the PR. Same with the local.env file.
See:
Line 56 in 82b91f9
danlipert
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove duplicate .env key
ETHERSCAN_API_KEYRefers/Fixes
Testing