Tribes light housekeeping #7143

[sanchaymittal]

Description

1. Add gitcoin staff to the tribe's admin view.

• user story: Help sponsors troubleshoot
  If I’m an admin of gitcoin, I should also see admin view of tribes (so core team can help)

2. Fixes All view sorting by contributor rank

• before: All people view section under tribe sorted based on the user id.
• change: Sort all people view on the basis of users contributor rank.

3. Fixes tribe bounty tab for the default view (!minor)

• Current bounties tab was only viewable if the user follows the tribe.
• Change the bounties tab is the default for the tribe.

4. Fixes tribe Townsquare sidebar shows follow the suggestion for the top member-based on contributor rank.

• Once the user is followed it will disappear from the list
• Top 10 profiles will be shown based on the contributor rank.
• Don't show current user profile in tribe Townsquare suggestion bar.

Refers/Fixes

#7143

Testing

[thelostone-mc]

• I'm not sure about lodash being added just for one usage! @octavioamu what do you think?
• Could we have video recording/ screenshots of what these changes are so that the product team can verify them

[sanchaymittal]

• I'm not sure about lodash being added just for one usage! @octavioamu what do you think?
• Could we have video recording/ screenshots of what these changes are so that the product team can verify them

I added loadash so it would be easy to add more functionalities for filters later on too.
I will add the recording/screenshots soon.

[octavioamu]

cool we are in general very strict with new libs additions but as loadsh is not more than 72kb I think is fine.

[octavioamu]

please after you add the video change it to ready to review so we can check it. The code looks fine.

[codecov]

Codecov Report

Merging #7171 into master will increase coverage by 8.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7171      +/-   ##
==========================================
+ Coverage   18.08%   26.18%   +8.09%     
==========================================
  Files         285      297      +12     
  Lines       29393    29385       -8     
  Branches     4366     4342      -24     
==========================================
+ Hits         5316     7694    +2378     
+ Misses      24065    21415    -2650     
- Partials       12      276     +264     

Impacted Files	Coverage Δ
...rketing/management/commands/no_applicants_email.py	0.00% <0.00%> (ø)
app/retail/templatetags/hash.py	57.14% <0.00%> (ø)
app/grants/templatetags/grants_extra.py	66.66% <0.00%> (ø)
app/dashboard/templatetags/add_url_schema.py	71.42% <0.00%> (ø)
app/kudos/templatetags/kudos_extras.py	70.00% <0.00%> (ø)
app/retail/templatetags/is_in_list_type_iexact.py	66.66% <0.00%> (ø)
app/retail/templatetags/matches.py	62.50% <0.00%> (ø)
app/dashboard/templatetags/jsonify.py	83.33% <0.00%> (ø)
app/retail/templatetags/is_in_list.py	66.66% <0.00%> (ø)
...pp/grants/templatetags/get_categories_from_list.py	50.00% <0.00%> (ø)
... and 85 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8401a49...77330fe. Read the comment docs.

[sanchaymittal]

@octavioamu @PixelantDesign Here's the walkthrough recording -> https://www.loom.com/share/7b55e1998cd84e579b7fb7e433e333d5

[sanchaymittal]

Features which this pr doesn't address:-

1. Sorting will happen based on the contributor rank, not by the winners (people who have been paid out) followed by contributor rank.
   Because I couldn't find any parameter which can help me figure out the previous winners associated with the tribe. And using a filter to check if the user's activity feed for bounty owners will make it slow. Need to make some dm changes around this. Which can be done while working on the product page.

2. project tab currently loads slowly, how can we speed this up?
   To speed up the project tab, it needs some DB changes as it loads all the project from hackathons. To fix this we need to filter out the projects based on sponsor and match it with the tribe which can be done more efficiently after the project pr changes are merged. So going to push this fix in the next pr while working on this issue. Tribes V2 - Next Iteration 09/11 #7098 (comment)
   @PixelantDesign

[PixelantDesign]

Looking good! @androolloyd are you able to help with the performance piece?

[danlipert]

@sanchaymittal Thanks for the PR - looks like there are a lot of automatic changes from your IDE where the files are being autoformatted. Can you please limit your changes to the relevant code for this issue and remove any of the changes that are style related? Generally we use eslint so as long as that passes then its good.

[PixelantDesign]

yayyyy