Fix/sponsors #7170

zoek1 · 2020-07-31T13:34:22Z

Description

clicking on profile link should open in a new tab for the sponsor
As a hackathon sponsor when I click on the GitHub cat - the GitHub project should open in a new tab
As a hackathon sponsor when I click on the Project link, the link should not 404. It should open the project link iii a new tab.
As a hackathon sponsor when I hover over the prize values, nothing should happen. Please remove hover states
as a Hackathon sponsor when I mark a winner - the pay button should appear next to the winner column. Clicking pay takes the sponsor to the normal payout flow in a new tab. Once sponsor's transaction goes through, then the view should update as paid with date on the submission view. See mockup.
clicking chat icon opens the chat window but it's displaying 404. Chat doesn't open the conversation with that user.
As a hackathon sponsor when I click the name of my prize - the prize details should open in a new tab.

Change Submission column header to Projects
Organize projects by most recently submitted at the top
For projects that haven't been submitted give a light gray background #F3F3F3 and a note that says Not Submitted
On the Add Note - add hint text inside the input field "this note can only be viewed by you"

https://www.loom.com/share/3522b328cd434198a80cf9cdb84c8fec

Refers/Fixes

#7158

Testing

PixelantDesign

Could we see a video @zoek1 ?
cc @thelostone-mc

zoek1 · 2020-08-04T11:45:53Z

@thelostone-mc @PixelantDesign https://www.loom.com/share/3522b328cd434198a80cf9cdb84c8fec

frankchen07 · 2020-08-04T22:13:27Z

from the short jam with @PixelantDesign & @vs77bb today:

I think it's a little confusing with the dual locations above and below. Isn't it just submitted work, or do we want to see started and submitted work?

Contacts and winners are nice, but it seems like it takes up alot of "space". Every row has a contact bubble - is there a way to coalesce some of those elements into the view somehow?

I understand the note is personal right now, and is only viewed on this page, but it might not be explicit to someone who is using this page. Do we think it's absolutely necessary?

frankchen07 · 2020-08-04T22:21:34Z

#7176 addresses some of the comments above

PixelantDesign · 2020-08-05T15:17:09Z

Looks great @zoek1! Could we make a few more updates?

Change Submission column header to Projects
Organize projects by most recently submitted at the top
For projects that haven't been submitted give a light gray background #F3F3F3 and a note that says Not Submitted
On the Add Note - add hint text inside the input field "this note can only be viewed by you"

codecov · 2020-08-07T01:41:05Z

Codecov Report

Merging #7170 into master will increase coverage by 0.00%.
The diff coverage is 7.69%.

@@           Coverage Diff           @@
##           master    #7170   +/-   ##
=======================================
  Coverage   26.18%   26.19%           
=======================================
  Files         297      297           
  Lines       29385    29405   +20     
  Branches     4342     4347    +5     
=======================================
+ Hits         7694     7702    +8     
- Misses      21415    21432   +17     
+ Partials      276      271    -5

Impacted Files	Coverage Δ
app/dashboard/views.py	`10.34% <0.00%> (-0.04%)`	⬇️
app/dashboard/models.py	`48.65% <22.22%> (-0.09%)`	⬇️
app/quests/views.py	`16.22% <0.00%> (ø)`
...rketing/management/commands/no_applicants_email.py	`0.00% <0.00%> (ø)`
...eting/management/commands/assemble_leaderboards.py	`39.73% <0.00%> (ø)`
app/dashboard/embed.py	`31.60% <0.00%> (+3.44%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e740b...4ba1467. Read the comment docs.

app/dashboard/templates/dashboard/sponsors.html

thelostone-mc · 2020-08-07T11:43:16Z

app/dashboard/templates/dashboard/sponsors.html

                                  [[ prize.total_submitted ]] / [[prize.total_projects]] Submitted
                                </span>
                                <span v-if="prize.paid" class="ml-5 gc-text-green"><span class="fas fa-check mr-2"></span>PAID</span>
-                                <a v-else :href="`/issue/payout?pk=${prize.pk}`" class="ml-2 ml-xl-5 btn btn-outline-primary font-smaller-5">PAY</a>
+                                <a v-else :href="`/issue/payout?pk=${prize.pk}`" class="ml-5 gc-text-blue">UNPAID</a>


Why was this changed back ? Could we keep it to what it was

@PixelantDesign request me change this to the previous implmementation

@PixelantDesign waiting on confirmation ^

What was the change y'all are referring to?

@zoek1 looks like it was never supposed to be a link in the first place!
If that is the case -> this makes sense but you'll have to remove the

I leave it to you and alisa to decide if on clicking this label -> it behaves as an accordion

thelostone-mc

@zoek1 looks like you sort of overwrote the HTML file while resolving the conflicts
Could you redo them just to add your changes ?

app/dashboard/templates/bounty/fulfill.html

thelostone-mc · 2020-08-07T11:46:52Z

app/dashboard/templates/dashboard/sponsors.html

-                                  <i class="fas fa-angle-up"></i>
+                                <b-button style="right: 0;top: -5px" class="position-absolute" v-if="prize.total_projects" v-b-toggle="`accordion-${prizeIndex}`" @click="togglePrize(prizeIndex)" variant="link">
+                                  <i class="fas fa-angle-up" v-if="!prize.open"></i>
+                                  <i class="fas fa-angle-down" v-else></i>


<i class="fas fa-angle-down" v-if="prize.open"></i> <i class="fas fa-angle-up" v-else></i>

app/dashboard/templates/dashboard/sponsors.html

PixelantDesign

The intention is to show an unpaid status. when user click it, it should just expand the row to see details.

The link was never intended to trigger payout flow. Not sure where that came from.

To make it even more we could show x/y Submitted Review Submission (this link will expand the accordian).

cc @thelostone-mc @zoek1

zoek1 · 2020-08-10T23:04:00Z

Comments from @PixelantDesign to get in sync the desired aspect of the dashboard

the alignment is off on the $ value, make it closer to where it was
when there is a submission …..change pay to review submission - but not make it a link
review submission expands the rows
github link should be under the projext title.

PixelantDesign · 2020-08-12T19:26:49Z

yayyyy

zoek1 added 3 commits July 28, 2020 21:05

rollback removed code that collapse sections on townsquare

a23bfa2

Merge branch 'stable' of https://github.com/gitcoinco/web into stable

527bf96

Add fixes for sponsor dashboard

b49c36f

zoek1 requested review from danlipert, frankchen07, octavioamu, PixelantDesign and thelostone-mc as code owners July 31, 2020 13:34

PixelantDesign reviewed Jul 31, 2020

View reviewed changes

danlipert marked this pull request as draft August 3, 2020 12:10

zoek1 marked this pull request as ready for review August 4, 2020 11:45

open profile in another tab

96a72d7

thelostone-mc marked this pull request as draft August 5, 2020 19:22

thelostone-mc changed the base branch from stable to master August 5, 2020 19:26

Next batch of QA fixes for sponsors

491d6de

zoek1 marked this pull request as ready for review August 7, 2020 01:34

Restore deleted localtime

7c4679d

thelostone-mc reviewed Aug 7, 2020

View reviewed changes

app/dashboard/templates/dashboard/sponsors.html Outdated Show resolved Hide resolved

thelostone-mc reviewed Aug 7, 2020

View reviewed changes

thelostone-mc requested changes Aug 7, 2020

View reviewed changes

thelostone-mc reviewed Aug 7, 2020

View reviewed changes

app/dashboard/templates/bounty/fulfill.html Outdated Show resolved Hide resolved

thelostone-mc reviewed Aug 7, 2020

View reviewed changes

app/dashboard/templates/dashboard/sponsors.html Show resolved Hide resolved

zoek1 added 2 commits August 9, 2020 09:44

Merge branch 'master' into fix/sponsors

085b564

Update models.py

cd58693

zoek1 added 2 commits August 10, 2020 05:25

Fix responsive view

2e9f399

Integrate from remote repo

6a688e5

zoek1 requested review from thelostone-mc and PixelantDesign August 10, 2020 10:29

danlipert approved these changes Aug 10, 2020

View reviewed changes

PixelantDesign reviewed Aug 10, 2020

View reviewed changes

Merge branch 'master' into fix/sponsors

d747367

Remove pay button on prize bar

4ba1467

thelostone-mc approved these changes Aug 12, 2020

View reviewed changes

thelostone-mc merged commit 477275e into gitcoinco:master Aug 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/sponsors #7170

Fix/sponsors #7170

zoek1 commented Jul 31, 2020 •

edited

Loading

PixelantDesign left a comment

zoek1 commented Aug 4, 2020

frankchen07 commented Aug 4, 2020

frankchen07 commented Aug 4, 2020

PixelantDesign commented Aug 5, 2020

codecov bot commented Aug 7, 2020 •

edited

Loading

thelostone-mc Aug 7, 2020

zoek1 Aug 9, 2020

thelostone-mc Aug 10, 2020

PixelantDesign Aug 10, 2020

thelostone-mc Aug 10, 2020

thelostone-mc left a comment

thelostone-mc Aug 7, 2020 •

edited

Loading

PixelantDesign left a comment

zoek1 commented Aug 10, 2020 •

edited

Loading

PixelantDesign commented Aug 12, 2020

Fix/sponsors #7170

Fix/sponsors #7170

Conversation

zoek1 commented Jul 31, 2020 • edited Loading

Description

Refers/Fixes

Testing

PixelantDesign left a comment

Choose a reason for hiding this comment

zoek1 commented Aug 4, 2020

frankchen07 commented Aug 4, 2020

frankchen07 commented Aug 4, 2020

PixelantDesign commented Aug 5, 2020

codecov bot commented Aug 7, 2020 • edited Loading

Codecov Report

thelostone-mc Aug 7, 2020

Choose a reason for hiding this comment

zoek1 Aug 9, 2020

Choose a reason for hiding this comment

thelostone-mc Aug 10, 2020

Choose a reason for hiding this comment

PixelantDesign Aug 10, 2020

Choose a reason for hiding this comment

thelostone-mc Aug 10, 2020

Choose a reason for hiding this comment

thelostone-mc left a comment

Choose a reason for hiding this comment

thelostone-mc Aug 7, 2020 • edited Loading

Choose a reason for hiding this comment

PixelantDesign left a comment

Choose a reason for hiding this comment

zoek1 commented Aug 10, 2020 • edited Loading

PixelantDesign commented Aug 12, 2020

zoek1 commented Jul 31, 2020 •

edited

Loading

codecov bot commented Aug 7, 2020 •

edited

Loading

thelostone-mc Aug 7, 2020 •

edited

Loading

zoek1 commented Aug 10, 2020 •

edited

Loading