New Email for Tribe Members about Hackathon Prizes #7146

sebastiantf · 2020-07-24T18:58:29Z

Description

This PR builds a new email that will be sent to the tribe members of a hackathon sponsor 3 days prior to the hackathon start date, listing out the prizes by that sponsor

Refers/Fixes

Fixes #7140

Screenshots (Updated after rewrite)

Gmail Web:

Gmail Mobile:

Web Preview:

codecov · 2020-07-24T19:05:35Z

Codecov Report

Merging #7146 into master will increase coverage by 0.06%.
The diff coverage is 5.08%.

@@            Coverage Diff             @@
##           master    #7146      +/-   ##
==========================================
+ Coverage   26.01%   26.08%   +0.06%     
==========================================
  Files         318      301      -17     
  Lines       31953    29757    -2196     
  Branches     4738     4416     -322     
==========================================
- Hits         8314     7761     -553     
+ Misses      23352    21724    -1628     
+ Partials      287      272      -15

Impacted Files	Coverage Δ
app/app/urls.py	`85.96% <ø> (-0.25%)`	⬇️
...anagement/commands/tribe_hackathon_prizes_email.py	`0.00% <0.00%> (ø)`
app/marketing/mails.py	`10.82% <4.16%> (-1.31%)`	⬇️
app/retail/emails.py	`20.91% <13.33%> (+0.10%)`	⬆️
app/economy/admin.py	`64.28% <0.00%> (-5.42%)`	⬇️
app/economy/utils.py	`88.57% <0.00%> (-2.13%)`	⬇️
app/grants/utils.py	`21.05% <0.00%> (-2.03%)`	⬇️
app/dashboard/models.py	`48.43% <0.00%> (-1.28%)`	⬇️
app/marketing/models.py	`64.03% <0.00%> (-1.24%)`	⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819401a...ce6fb73. Read the comment docs.

PixelantDesign

Looks good to me if it looks good to @willsputra!

danlipert · 2020-07-28T08:28:47Z

@PixelantDesign @connoroday This will send multiple emails to the same user if they are members of multiple tribes that are participating in the hackathon - we need to combine the emails so each user only gets one I think @sebastiantf

sebastiantf · 2020-07-28T08:53:07Z

Combining all the bounties by all the sponsors/tribes the user is part of, might make the email a lot big in content. Aren't most users part of a lot number of tribes? Just my thoughts. What do you think @PixelantDesign?

PixelantDesign · 2020-08-04T13:57:32Z

If the user is part of two tribes participating in the same hackathon, they should receive just 1 email if possible.

sebastiantf · 2020-08-05T16:53:41Z

If the user is part of two tribes participating in the same hackathon, they should receive just 1 email if possible.

If that's the case, I would have to rewrite what I've did now for this email. And I would need some time for that

PixelantDesign · 2020-08-25T14:25:37Z

@sebastiantf are you still interested in this ticket?

sebastiantf · 2020-08-25T14:33:55Z

Yeah @PixelantDesign. I'm a bit caught up is all. Will get on this asap

sebastiantf · 2020-08-27T07:22:07Z

@PixelantDesign @danlipert Extremely sorry for the delay. I have rewritten the logic to combine all bounties of all tribes of a member into single email. Please review

I have also updated the screenshots

PixelantDesign · 2020-08-28T11:50:21Z

Thanks @sebastiantf Looks good!

Just to clarify -
When a hackathon starts users who follow the organization will receive this email that explains the prizes associated with the hackathon, correct?

Not all users will receive this email.

sebastiantf · 2020-08-28T11:57:19Z

Yes @PixelantDesign. Only the tribe members of the org who are sponsors in the hackathon would receive this email

PixelantDesign · 2020-09-08T08:04:15Z

great! are you able to provide a video or screenshot of this?

sebastiantf · 2020-09-08T08:07:03Z

great! are you able to provide a video or screenshot of this?

I have already updated the screenshots in the opening comment: #7146 (comment)

frankchen07

LGTM as long as we don't have duplicate emails across multiple tribes, which sounds like it was fixed.

Last item: is there an option for the user to opt-out of tribe specific communications or is that out of scope for this ticket?

PixelantDesign · 2020-09-08T20:49:46Z

@frankchen07 I think I'll open another ticket for that....@sebastiantf what do you think? A simple checkbox in the email tab of the settings should do it.

sebastiantf · 2020-09-09T03:52:47Z

@frankchen07 I think I'll open another ticket for that....@sebastiantf what do you think? A simple checkbox in the email tab of the settings should do it.

Yeah @PixelantDesign guess a simple setting to keep along with the other email settings

willsputra · 2020-09-21T15:48:57Z

looks good to me!

PixelantDesign · 2020-09-23T13:25:10Z

@thelostone-mc could we have a review on this? it's for October

thelostone-mc · 2020-09-29T12:43:52Z

@sebastiantf gimme a ping when you resolve the conflicts and we can get this in

sebastiantf · 2020-09-30T06:18:13Z

@thelostone-mc I have resolved the conflicts and pushed again

octavioamu

doing regression test I saw this problem, can you submit a PR to fix this using sponsor_profiles?

octavioamu · 2020-09-30T18:24:47Z

app/marketing/mails.py

+    from dashboard.models import TribeMember, Sponsor
+    from marketing.utils import generate_hackathon_email_intro
+
+    sponsors = hackathon.sponsors.all()


we have a problem here, should use sponsor_profiles we not longer use Sponsors to control hackathons

@octavioamu @PixelantDesign I have a PR up at #7589

PixelantDesign · 2020-10-01T19:53:25Z

@sebastiantf can you take a look please? :)

sebastiantf requested review from danlipert, frankchen07, octavioamu, PixelantDesign and thelostone-mc as code owners July 24, 2020 18:58

sebastiantf mentioned this pull request Jul 24, 2020

Email tribe members about hackathon prizes #7140

Closed

7 tasks

octavioamu approved these changes Jul 28, 2020

View reviewed changes

PixelantDesign reviewed Jul 28, 2020

View reviewed changes

PixelantDesign requested a review from willsputra July 28, 2020 03:02

danlipert marked this pull request as draft July 28, 2020 08:30

sebastiantf force-pushed the tribe-hackathon-prizes-email branch from 16a6632 to 4baffd3 Compare August 26, 2020 12:09

sebastiantf marked this pull request as ready for review August 27, 2020 07:22

PixelantDesign requested a review from connoroday August 28, 2020 11:50

PixelantDesign added the October Hacks label Sep 8, 2020

connoroday approved these changes Sep 8, 2020

View reviewed changes

frankchen07 reviewed Sep 8, 2020

View reviewed changes

willsputra approved these changes Sep 21, 2020

View reviewed changes

sebastiantf added 11 commits September 30, 2020 11:42

setup web preview url

1e8d208

implement render_tribe_hackathon_prizes

79fbc4c

add new email_header_hackathon.png banner image

eb1fe5b

build template for tribe_hackathon_prizes_email

e874005

management command for tribe_hackathon_prizes

a2ae49c

setup cron job

3241223

email intro util function

67a4609

rewrite tribe_hackathon_prizes()

b67f24e

rewrite render_tribe_hackathon_prizes()

688dad1

rewrite web preview function

80b733c

rewrite template()

ce6fb73

sebastiantf force-pushed the tribe-hackathon-prizes-email branch from 6f1cdfe to ce6fb73 Compare September 30, 2020 06:17

thelostone-mc merged commit 0632270 into gitcoinco:master Sep 30, 2020

octavioamu reviewed Sep 30, 2020

View reviewed changes

willsputra mentioned this pull request Oct 1, 2020

[DESIGN] Following a Tribe, What do I get? #7553

Closed

sebastiantf mentioned this pull request Oct 2, 2020

Use sponsor_profiles instead of sponsors #7589

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Email for Tribe Members about Hackathon Prizes #7146

New Email for Tribe Members about Hackathon Prizes #7146

sebastiantf commented Jul 24, 2020 •

edited

Loading

codecov bot commented Jul 24, 2020 •

edited

Loading

PixelantDesign left a comment

danlipert commented Jul 28, 2020

sebastiantf commented Jul 28, 2020

PixelantDesign commented Aug 4, 2020

sebastiantf commented Aug 5, 2020

PixelantDesign commented Aug 25, 2020

sebastiantf commented Aug 25, 2020

sebastiantf commented Aug 27, 2020 •

edited

Loading

PixelantDesign commented Aug 28, 2020

sebastiantf commented Aug 28, 2020

PixelantDesign commented Sep 8, 2020

sebastiantf commented Sep 8, 2020

frankchen07 left a comment

PixelantDesign commented Sep 8, 2020

sebastiantf commented Sep 9, 2020

willsputra commented Sep 21, 2020

PixelantDesign commented Sep 23, 2020

thelostone-mc commented Sep 29, 2020

sebastiantf commented Sep 30, 2020

octavioamu left a comment

octavioamu Sep 30, 2020

sebastiantf Oct 2, 2020

PixelantDesign commented Oct 1, 2020

New Email for Tribe Members about Hackathon Prizes #7146

New Email for Tribe Members about Hackathon Prizes #7146

Conversation

sebastiantf commented Jul 24, 2020 • edited Loading

Description

Refers/Fixes

Screenshots (Updated after rewrite)

codecov bot commented Jul 24, 2020 • edited Loading

Codecov Report

PixelantDesign left a comment

Choose a reason for hiding this comment

danlipert commented Jul 28, 2020

sebastiantf commented Jul 28, 2020

PixelantDesign commented Aug 4, 2020

sebastiantf commented Aug 5, 2020

PixelantDesign commented Aug 25, 2020

sebastiantf commented Aug 25, 2020

sebastiantf commented Aug 27, 2020 • edited Loading

PixelantDesign commented Aug 28, 2020

sebastiantf commented Aug 28, 2020

PixelantDesign commented Sep 8, 2020

sebastiantf commented Sep 8, 2020

frankchen07 left a comment

Choose a reason for hiding this comment

PixelantDesign commented Sep 8, 2020

sebastiantf commented Sep 9, 2020

willsputra commented Sep 21, 2020

PixelantDesign commented Sep 23, 2020

thelostone-mc commented Sep 29, 2020

sebastiantf commented Sep 30, 2020

octavioamu left a comment

Choose a reason for hiding this comment

octavioamu Sep 30, 2020

Choose a reason for hiding this comment

sebastiantf Oct 2, 2020

Choose a reason for hiding this comment

PixelantDesign commented Oct 1, 2020

sebastiantf commented Jul 24, 2020 •

edited

Loading

codecov bot commented Jul 24, 2020 •

edited

Loading

sebastiantf commented Aug 27, 2020 •

edited

Loading