Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bounty form #7086

Merged
merged 16 commits into from
Jul 24, 2020
Merged

New bounty form #7086

merged 16 commits into from
Jul 24, 2020

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Jul 10, 2020

Description
  • Adds new funder form
  • Introduce subscriptions model

The new funder form was rebuild from zero removing standard bounties but keeping 10% fees and featured bounty.
For non ethereum 10% fees are not applied, but if the bounty is featured then user need to do that transaction.

Guide was moved to a modal, no longer redirect.

Subscribers doesn't have any charge on fees or featured bounties.

Coupons still a valid use case.

Chains selectors let people chose their chain.

Contest and cooperative only for subscriptions.

paypal, others, celo only visible for staff.

new param for get_issue_details duplicates=true to check if there is a bounty already for that issue.
/sync/get_issue_details?url=https://github.com/gitcoinco/web/issues/7111&duplicates=true

Refers/Fixes
Testing

Copy link
Contributor

@PixelantDesign PixelantDesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a video @octavioamu ?

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #7086 into stable will decrease coverage by 0.18%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #7086      +/-   ##
==========================================
- Coverage   26.25%   26.06%   -0.19%     
==========================================
  Files         300      300              
  Lines       29385    29769     +384     
  Branches     4325     4497     +172     
==========================================
+ Hits         7715     7760      +45     
- Misses      21399    21729     +330     
- Partials      271      280       +9     
Impacted Files Coverage Δ
app/dashboard/helpers.py 14.28% <0.00%> (-0.19%) ⬇️
app/dashboard/views.py 10.40% <0.00%> (-0.17%) ⬇️
app/dashboard/models.py 48.61% <60.00%> (+0.07%) ⬆️
app/dashboard/admin.py 60.59% <100.00%> (+0.39%) ⬆️
app/dashboard/tip_views.py 13.71% <0.00%> (-0.46%) ⬇️
app/quests/views.py 16.22% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 39.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d65ba0...14e9a37. Read the comment docs.

@octavioamu octavioamu marked this pull request as ready for review July 22, 2020 13:41
@octavioamu octavioamu merged commit 01502cc into stable Jul 24, 2020
octavioamu added a commit that referenced this pull request Jul 24, 2020
* removes per tip txn limit (#7101)

* removes tip per txn limit

* removes tip per txn limit

* removes tip per txn limit

* allow matic grant creation w/o web3 (#7118)

* allow matic grant creation w/o web3

* remove consolelog

* fix lint

* fix network assignment for grants w/o web3

* fix matic label in grants index

* gas prices threshold

* avatar URL

* New bounty form (#7086)

* create new form

* set fee

* add missing fields and fix datepicker

* form fees and featured

* url params

* add subscriptions models

* subscription validations and wallet tx counter

* cleanup

* migration

* hide chains

* add duplication validate

* add decimals filter

* fix validations

* code review

* new form fixes

Co-authored-by: Kevin Owocki <[email protected]>
Co-authored-by: Dan Lipert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants